Remove unused constructor from ControlInfoDocLink class#1870
Merged
marcelwgn merged 5 commits intomicrosoft:mainfrom May 14, 2025
Merged
Remove unused constructor from ControlInfoDocLink class#1870marcelwgn merged 5 commits intomicrosoft:mainfrom
ControlInfoDocLink class#1870marcelwgn merged 5 commits intomicrosoft:mainfrom
Conversation
Replaced the `WASDK` alias with a direct reference to `Microsoft.Windows.ApplicationModel.WindowsAppRuntime`, in `ControlInfoData.cs` Updated the URI construction in `ControlInfoDocLink` to use `ReleaseInfo.Major` and `ReleaseInfo.Minor` for version information, reflecting changes in version management within the application.
Contributor
|
Thank you for making this change, however I dont think we still need this code at all. Searching for X.Y did not yield any results beside that replacement 😄 |
Contributor
Author
Good point, should we remove that logic? |
Contributor
|
Yes I think we can remove it now given we should point to winui main anyway. |
Zakariathr22
changed the title
ControlInfoDocLinkControlInfoDocLink class
Contributor
Author
Done! |
Contributor
|
/azp run |
marcelwgn
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Manually tested
Screenshots (if appropriate):
Types of changes