Skip to content

Add internal page scrolling functionality#1884

Merged
niels9001 merged 2 commits intomainfrom
niels9001/scrolling
May 26, 2025
Merged

Add internal page scrolling functionality#1884
niels9001 merged 2 commits intomainfrom
niels9001/scrolling

Conversation

@niels9001
Copy link
Copy Markdown
Collaborator

@niels9001 niels9001 commented May 26, 2025

In certain edge cases, we don't want the entire page to scroll but only a specific part of the page (e.g. the Colors and Icons pages).

This PR introduces an attached DP that can be set on a page to enable this.

Closes: #1858 (comment)

@niels9001 niels9001 requested a review from marcelwgn May 26, 2025 14:58
@niels9001
Copy link
Copy Markdown
Collaborator Author

/azp run

@niels9001 niels9001 requested a review from snigdha011997 May 26, 2025 15:25
@niels9001 niels9001 enabled auto-merge (squash) May 26, 2025 17:32
Copy link
Copy Markdown
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent fix!

@niels9001 niels9001 merged commit b9568fa into main May 26, 2025
2 checks passed
@niels9001 niels9001 deleted the niels9001/scrolling branch May 26, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Textscaling issues

3 participants