Conversation
|
Add a screenshot in the description, highlighting the disperancy. |
|
/azp run |
| private void TestButtonClick2(object sender, RoutedEventArgs e) | ||
| private void TestButton2Click(object sender, RoutedEventArgs e) | ||
| { | ||
| ToggleThemeTeachingTip2.IsOpen = true; |
There was a problem hiding this comment.
Does any element with name "ToggleThemeTeachingTip2" exist in the XAML? I don't see any changes regarding this. The tooltip present inside the button has a different name in the screenshots
There was a problem hiding this comment.
Nit: You could use code blocks (e.g. triple backticks ``` in Markdown) to display code instead of screenshots. This makes it easier for reviewers to copy/paste and provide feedback.
There was a problem hiding this comment.
@rashmi-thakurr you need to correct naming of ToggleThemeTeachingTip2 in C# file as well. In Xaml, the name is TestButton2TeachingTip
There was a problem hiding this comment.
Thanks for pointing this out. I've addressed the issue in a follow-up PR here: #1922
7 participants
Teaching Tip Bug Fix
Description
This pull request corrects a textual mismatch in the C# code snippet associated with the TeachingTip button in the WinU3 Gallery app. The XAML markup correctly referenced the Click="TestButton2Click" event, but the C# method was mistakenly named TestButtonClick2. The method name has been updated to TestButton2Click to match the XAML and ensure clarity in the codebase.
Motivation and Context
Although the TeachingTip functionality was working as expected in the app, the discrepancy between the XAML and C# method name could cause confusion for future maintainers or contributors.
How Has This Been Tested?
No functional testing was required as the app behavior was already correct. The change was verified by reviewing the code to ensure the method name now matches the XAML event handler.
Screenshots
Xaml Code
C# code
Types of changes