Fix incorrect heading levels for Home page section headings#1973
Merged
Fix incorrect heading levels for Home page section headings#1973
Conversation
Co-authored-by: niels9001 <9866362+niels9001@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WinUI 3 Gallery: Home]: Incorrect heading level is defined for 'Recently added samples' heading.
Fix incorrect heading levels for Home page section headings
Jul 30, 2025
niels9001
approved these changes
Jul 30, 2025
Collaborator
|
/azp run |
marcelwgn
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an accessibility issue where section headings on the Home page were being announced by screen readers as "heading level 1" instead of the appropriate "heading level 2".
Problem
Screen reader users navigating the WinUI 3 Gallery Home page in headings mode experienced incorrect heading level announcements for:
These headings were missing proper
AutomationProperties.HeadingLevelattributes, causing them to default to level 1, which breaks the document's heading hierarchy.Solution
Added
AutomationProperties.HeadingLevel="Level2"to both TextBlock elements serving as section headings inHomePage.xaml:Impact
The changes are minimal and surgical, affecting only the specific elements mentioned in the accessibility issue while maintaining consistency with established patterns in the accessibility sample pages.
Fixes #1955.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
e7bvsblobprodcus348.vsblob.vsassets.iodotnet build WinUIGallery.sln --configuration Debug(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.