Fix: sync titlebar button colors with app theme changes#2016
Merged
marcelwgn merged 1 commit intomicrosoft:mainfrom Aug 12, 2025
Merged
Fix: sync titlebar button colors with app theme changes#2016marcelwgn merged 1 commit intomicrosoft:mainfrom
marcelwgn merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@niels9001 @marcelwgn |
marcelwgn
approved these changes
Aug 12, 2025
Contributor
marcelwgn
left a comment
marcelwgn
left a comment
There was a problem hiding this comment.
Thank you for fixing this! Not sure why exactly we went with UISettings in the first place 😄
Contributor
|
/azp run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the app theme is set to Light or Dark (not “Use system setting”) and the app theme differs from the system theme, the app initially opens in the system theme and then switches to the chosen app theme.
Previously, the titlebar button colors were not updated during this theme change, resulting in low contrast.
This fix updates the button colors whenever the root grid theme changes and removes the old broken logic.
Motivation and Context
How Has This Been Tested?
Manually tested
Screenshots (if appropriate):
Types of changes