Skip to content

feat: enhance icon tags with British variants, synonyms, and cleanup#2058

Merged
marcelwgn merged 6 commits intomicrosoft:mainfrom
Zakariathr22:feature/icon-tag-enhancements
Sep 28, 2025
Merged

feat: enhance icon tags with British variants, synonyms, and cleanup#2058
marcelwgn merged 6 commits intomicrosoft:mainfrom
Zakariathr22:feature/icon-tag-enhancements

Conversation

@Zakariathr22
Copy link
Contributor

Description

Applied the modifications as recommended in this comment: #2057 (comment)

Motivation and Context

Closes #2057

How Has This Been Tested?

Manually tested

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@AndrewKeepCoding
Copy link
Contributor

Hi @Zakariathr22.
My 2 cents…
I’m not sure if we should add tags that simply duplicate the name, or tags that only differ by British spelling. Since filtering already applies to both the name and the tags, I wonder if adding these might be unnecessary. We probably want to avoid extra tags unless they really improve discoverability, just to keep things clean and avoid space issues.
Just my 2 cents.🙂

@Zakariathr22
Copy link
Contributor Author

Hi @Zakariathr22.
My 2 cents…
I’m not sure if we should add tags that simply duplicate the name, or tags that only differ by British spelling. Since filtering already applies to both the name and the tags, I wonder if adding these might be unnecessary. We probably want to avoid extra tags unless they really improve discoverability, just to keep things clean and avoid space issues.
Just my 2 cents.🙂

I understand your point.
Well, I’ll leave it to the maintainers to decide whether they want to accept it or close it.

@AndrewKeepCoding
Copy link
Contributor

AndrewKeepCoding commented Sep 24, 2025

To be clear, I'm referring to:

  • tags that simply duplicate the name
  • tags that only differ by spelling (e.g British vs US)

The other new tags are definitely helpful. 🙂

@Zakariathr22
Copy link
Contributor Author

  • tags that simply duplicate the name

Actually, I can't find any tag that duplicates the name of an icon. Did I miss something?

  • tags that only differ by spelling (e.g British vs US)

I think adding British spelling would be helpful for some users

@niels9001 I would like to know your opinion on this

@AndrewKeepCoding
Copy link
Contributor

Actually, I can't find any tag that duplicates the name of an icon. Did I miss something?

Sorry, my bad. 😓

Copy link
Contributor

@AndrewKeepCoding AndrewKeepCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding British spelling would be helpful for some users

Copilot found "organize (organise)".

@Zakariathr22
Copy link
Contributor Author

organize

Done!

Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! I think we should keep the British spellings for inclusivity. There is one small formatting error, otherwise changes look good :)

Edit: Forgot I can push to the branch, lets get this merged!

@marcelwgn
Copy link
Contributor

/azp run

@marcelwgn marcelwgn enabled auto-merge (squash) September 28, 2025 11:55
@marcelwgn
Copy link
Contributor

/azp run

@marcelwgn marcelwgn merged commit 2c0b8b5 into microsoft:main Sep 28, 2025
2 checks passed
@Zakariathr22 Zakariathr22 deleted the feature/icon-tag-enhancements branch September 28, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Color' icon tags

3 participants