Disable temperature converter button when input is empty#2090
Merged
Disable temperature converter button when input is empty#2090
Conversation
Co-authored-by: ayushjai19 <244442986+ayushjai19@users.noreply.github.com>
…tion Co-authored-by: ayushjai19 <244442986+ayushjai19@users.noreply.github.com>
…eException Co-authored-by: ayushjai19 <244442986+ayushjai19@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix enabled state of convert to Fahrenheit button
Disable temperature converter button when input is empty
Dec 18, 2025
marcelwgn
approved these changes
Dec 18, 2025
Contributor
|
/azp run |
Zakariathr22
suggested changes
Dec 18, 2025
Contributor
Zakariathr22
left a comment
Zakariathr22
left a comment
There was a problem hiding this comment.
You can simplify the IsEnabled logic and avoid INotifyPropertyChanged entirely by using an x:Bind function binding. Since the button state is directly derived from the TextBox.Text, a small method is sufficient and keeps the control lightweight.
IsEnabled="{x:Bind HasText(InputTextBox.Text), Mode=OneWay}"private bool HasText(string text)
{
return !string.IsNullOrWhiteSpace(text);
}
Collaborator
@copilot consider above comment |
Co-authored-by: ayushjai19 <244442986+ayushjai19@users.noreply.github.com>
Contributor
Author
Implemented the simplified approach using x:Bind function binding in commit f10e4e3. The solution is now much cleaner with just a Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
marcelwgn
approved these changes
Dec 19, 2025
Zakariathr22
approved these changes
Dec 19, 2025
Contributor
|
/azp run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Convert to Fahrenheit" button in the Temperature Converter UserControl was always enabled, allowing users to click it with no input.
Changes
TemperatureConverterControl.xaml
IsEnabledproperty toHasText(InputTextBox.Text)using x:Bind function bindingTemperatureConverterControl.xaml.cs
HasText(string text)helper method!string.IsNullOrWhiteSpace(text)This implementation uses x:Bind function binding which automatically reevaluates when
InputTextBox.Textchanges, providing a lightweight solution without the need forINotifyPropertyChanged, event handlers, or backing fields.Button state now updates in real-time as user types.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.