Skip to content

fix: IndexError in detect_media_type_from_base64 for non-base64 data … #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Serjbory wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

fix: IndexError in detect_media_type_from_base64 for non-base64 data … #5114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/packages/core/agent_framework/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ def detect_media_type_from_base64(
if data is not None:
raise ValueError("Provide exactly one of data_bytes, data_str, or data_uri.")
# Remove data URI prefix if present
if ";base64," not in data_uri:
raise ValueError("Data URI must use base64 encoding.")
data_str = data_uri.split(";base64,", 1)[1]
if data_str is not None:
if data is not None:
Expand Down
5 changes: 5 additions & 0 deletions python/packages/core/tests/core/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,11 @@ def test_data_content_detect_image_format_from_base64():
detect_media_type_from_base64(data_bytes=b"data", data_uri="data:application/octet-stream;base64,AAA")
detect_media_type_from_base64(data_str="data", data_uri="data:application/octet-stream;base64,AAA")

with pytest.raises(ValueError, match="Data URI must use base64 encoding"):
detect_media_type_from_base64(data_uri="data:text/plain,Hello%20World")
with pytest.raises(ValueError, match="Data URI must use base64 encoding"):
detect_media_type_from_base64(data_uri="http://example.com/image.png")


def test_data_content_create_data_uri_from_base64():
"""Test the create_data_uri_from_base64 class method."""
Expand Down
Loading