Skip to content

Normalize connection string environment variable aliases - #19729

Merged
Sébastien Ros (sebastienros) merged 20 commits into
mainfrom
sebros/connection-string-normalization
Sep 22, 2026
Merged

Sébastien Ros (sebastienros) merged 20 commits into
mainfrom
sebros/connection-string-normalization

Conversation

@sebastienros

@sebastienros Sébastien Ros (sebastienros) commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Description

Connection-string environment variables currently preserve the logical resource name, so a resource such as my-db produces ConnectionStrings__my-db. Names containing characters such as - are rejected or mishandled by strict deployment targets, which can make an otherwise valid AppHost fail during deployment.

This change separates logical connection names from physical environment-variable names:

  • WithReference preserves the logical .NET configuration name and emits both the legacy and portable physical aliases when the target supports them.
  • Portable aliases use a shared encoder, avoid nested __ configuration delimiters, and fail early on case-insensitive collisions.
  • Azure App Service and Kubernetes project only the portable alias while retaining validation for unrelated invalid environment variables.
  • Aspire client integrations resolve the logical key through the composed configuration first, then fall back to the portable key.
  • Qdrant supplemental HTTP references and EF migration bundles use the same naming contract.
  • The migration path and guidance for direct IConfiguration consumers are documented.

User-facing usage

Existing AppHost code remains unchanged:

var database = builder.AddPostgres("postgres")
    .AddDatabase("my-db");

builder.AddProject<Projects.Api>("api")
    .WithReference(database);

Capable targets receive ConnectionStrings__my-db and ConnectionStrings__my_db. Strict targets receive ConnectionStrings__my_db, and updated Aspire integrations resolve it using the logical name my-db.

Applications using older integrations or direct configuration lookup on strict targets can migrate explicitly:

builder.AddProject<Projects.Api>("api")
    .WithReference(database, connectionName: "my_db");

Validation

  • Targeted hosting, App Service, Kubernetes, Qdrant, EF migration, SQL client, and Key Vault tests
  • Repository build with native compilation skipped
  • Generated Bicep and Kubernetes snapshot coverage

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: af599a10-84bd-4288-8f55-3e9915433275
Copilot AI balanced review requested due to automatic review settings August 26, 2026 23:40
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19729

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19729"

@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 26, 2026
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Normalizes connection-string environment aliases across hosting, deployment targets, client integrations, and migration tooling.

Changes:

  • Adds shared portable-name encoding, metadata, and collision validation.
  • Updates App Service, Kubernetes, Qdrant, EF migrations, and client integrations.
  • Adds unit tests, deployment snapshots, and migration guidance.

Reviewed changes

Copilot reviewed 82 out of 82 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/Aspire.Microsoft.Data.SqlClient.Tests/ConnectionStringConfigurationExtensionsTests.cs Tests alias resolution and precedence.
tests/Aspire.Microsoft.Data.SqlClient.Tests/AspireSqlServerSqlClientExtensionsTests.cs Tests portable SQL keys.
tests/Aspire.Microsoft.Data.SqlClient.Tests/Aspire.Microsoft.Data.SqlClient.Tests.csproj Links shared resolver sources.
tests/Aspire.Hosting.Tests/WithReferenceTests.cs Tests aliases and collisions.
tests/Aspire.Hosting.Qdrant.Tests/AddQdrantTests.cs Tests Qdrant aliases.
tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_HandlesSpecialResourceName#06.verified.yaml Updates Secret snapshot.
tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_HandlesSpecialResourceName#05.verified.yaml Updates ConfigMap snapshot.
tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_HandlesSpecialResourceName#01.verified.yaml Updates Helm values snapshot.
tests/Aspire.Hosting.Kubernetes.Tests/KubernetesPublisherTests.cs Covers Kubernetes alias projection.
tests/Aspire.Hosting.EntityFrameworkCore.Tests/EFMigrationPipelineTests.cs Tests portable migration variable.
tests/Aspire.Hosting.Azure.Tests/Snapshots/AzureAppServiceTests.PublishToAppService_WithDashedConnectionStringName_UsesPortableAlias.verified.bicep Adds App Service snapshot.
tests/Aspire.Hosting.Azure.Tests/AzureAppServiceTests.cs Tests App Service projection and validation.
tests/Aspire.Azure.Security.KeyVault.Tests/AspireKeyVaultExtensionsTests.cs Tests portable Key Vault keys.
src/Shared/EnvironmentVariableNameEncoder.cs Adds connection-name encoding.
src/Components/Common/ConnectionStringConfigurationExtensions.cs Adds provider-aware resolution.
src/Components/Common/AzureComponent.cs Uses shared resolver.
src/Components/Aspire.StackExchange.Redis/AspireRedisExtensions.cs Resolves portable Redis keys.
src/Components/Aspire.StackExchange.Redis/Aspire.StackExchange.Redis.csproj Links resolver sources.
src/Components/Aspire.Seq/AspireSeqExtensions.cs Resolves portable Seq keys.
src/Components/Aspire.Seq/Aspire.Seq.csproj Links resolver sources.
src/Components/Aspire.RabbitMQ.Client/AspireRabbitMQExtensions.cs Resolves portable RabbitMQ keys.
src/Components/Aspire.RabbitMQ.Client/Aspire.RabbitMQ.Client.csproj Links resolver sources.
src/Components/Aspire.RabbitMQ.Client.v6/Aspire.RabbitMQ.Client.v6.csproj Links resolver sources.
src/Components/Aspire.Qdrant.Client/AspireQdrantExtensions.cs Resolves portable Qdrant keys.
src/Components/Aspire.Qdrant.Client/Aspire.Qdrant.Client.csproj Links resolver sources.
src/Components/Aspire.Pomelo.EntityFrameworkCore.MySql/AspireEFMySqlExtensions.cs Resolves portable MySQL keys.
src/Components/Aspire.Pomelo.EntityFrameworkCore.MySql/Aspire.Pomelo.EntityFrameworkCore.MySql.csproj Links resolver sources.
src/Components/Aspire.Oracle.EntityFrameworkCore/AspireOracleEFCoreExtensions.cs Resolves portable Oracle keys.
src/Components/Aspire.Oracle.EntityFrameworkCore/Aspire.Oracle.EntityFrameworkCore.csproj Links resolver sources.
src/Components/Aspire.OpenAI/AspireOpenAIExtensions.cs Resolves portable OpenAI keys.
src/Components/Aspire.OpenAI/AspireOpenAIClientBuilder.cs Resolves portable deployment keys.
src/Components/Aspire.OpenAI/Aspire.OpenAI.csproj Links resolver sources.
src/Components/Aspire.Npgsql/AspirePostgreSqlNpgsqlExtensions.cs Resolves portable PostgreSQL keys.
src/Components/Aspire.Npgsql/Aspire.Npgsql.csproj Links resolver sources.
src/Components/Aspire.Npgsql.EntityFrameworkCore.PostgreSQL/AspireEFPostgreSqlExtensions.cs Resolves portable EF PostgreSQL keys.
src/Components/Aspire.Npgsql.EntityFrameworkCore.PostgreSQL/Aspire.Npgsql.EntityFrameworkCore.PostgreSQL.csproj Links resolver sources.
src/Components/Aspire.NATS.Net/AspireNatsClientExtensions.cs Resolves portable NATS keys.
src/Components/Aspire.NATS.Net/Aspire.NATS.Net.csproj Links resolver sources.
src/Components/Aspire.MySqlConnector/AspireMySqlConnectorExtensions.cs Resolves portable MySQL keys.
src/Components/Aspire.MySqlConnector/Aspire.MySqlConnector.csproj Links resolver sources.
src/Components/Aspire.MongoDB.EntityFrameworkCore/AspireMongoDBEntityFrameworkCoreExtensions.cs Resolves portable MongoDB EF keys.
src/Components/Aspire.MongoDB.EntityFrameworkCore/Aspire.MongoDB.EntityFrameworkCore.csproj Links resolver sources.
src/Components/Aspire.MongoDB.Driver/AspireMongoDBDriverExtensions.cs Resolves portable MongoDB keys.
src/Components/Aspire.MongoDB.Driver/Aspire.MongoDB.Driver.csproj Links resolver sources.
src/Components/Aspire.MongoDB.Driver.v2/Aspire.MongoDB.Driver.v2.csproj Links resolver sources.
src/Components/Aspire.Milvus.Client/AspireMilvusExtensions.cs Resolves portable Milvus keys.
src/Components/Aspire.Milvus.Client/Aspire.Milvus.Client.csproj Links resolver sources.
src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/AspireAppConfigurationExtensions.cs Resolves portable App Configuration keys.
src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration.csproj Links resolver sources.
src/Components/Aspire.Microsoft.EntityFrameworkCore.SqlServer/AspireSqlServerEFCoreSqlClientExtensions.cs Resolves portable EF SQL keys.
src/Components/Aspire.Microsoft.EntityFrameworkCore.SqlServer/Aspire.Microsoft.EntityFrameworkCore.SqlServer.csproj Links resolver sources.
src/Components/Aspire.Microsoft.EntityFrameworkCore.Cosmos/AspireAzureEFCoreCosmosExtensions.cs Resolves portable Cosmos EF keys.
src/Components/Aspire.Microsoft.EntityFrameworkCore.Cosmos/Aspire.Microsoft.EntityFrameworkCore.Cosmos.csproj Links resolver sources.
src/Components/Aspire.Microsoft.Data.SqlClient/AspireSqlServerSqlClientExtensions.cs Resolves portable SQL keys.
src/Components/Aspire.Microsoft.Data.SqlClient/Aspire.Microsoft.Data.SqlClient.csproj Links resolver sources.
src/Components/Aspire.Microsoft.Azure.Cosmos/AspireMicrosoftAzureCosmosExtensions.cs Resolves portable Cosmos keys.
src/Components/Aspire.Microsoft.Azure.Cosmos/Aspire.Microsoft.Azure.Cosmos.csproj Links resolver sources.
src/Components/Aspire.Confluent.Kafka/AspireKafkaProducerExtensions.cs Resolves portable producer keys.
src/Components/Aspire.Confluent.Kafka/AspireKafkaConsumerExtensions.cs Resolves portable consumer keys.
src/Components/Aspire.Confluent.Kafka/Aspire.Confluent.Kafka.csproj Links resolver sources.
src/Components/Aspire.Azure.Storage.Queues/Aspire.Azure.Storage.Queues.csproj Links resolver sources.
src/Components/Aspire.Azure.Storage.Files.DataLake/Aspire.Azure.Storage.Files.DataLake.csproj Links resolver sources.
src/Components/Aspire.Azure.Storage.Blobs/Aspire.Azure.Storage.Blobs.csproj Links resolver sources.
src/Components/Aspire.Azure.Security.KeyVault/AspireKeyVaultExtensions.cs Resolves portable Key Vault keys.
src/Components/Aspire.Azure.Security.KeyVault/Aspire.Azure.Security.KeyVault.csproj Links resolver sources.
src/Components/Aspire.Azure.Search.Documents/Aspire.Azure.Search.Documents.csproj Links resolver sources.
src/Components/Aspire.Azure.Messaging.WebPubSub/Aspire.Azure.Messaging.WebPubSub.csproj Links resolver sources.
src/Components/Aspire.Azure.Messaging.ServiceBus/Aspire.Azure.Messaging.ServiceBus.csproj Links resolver sources.
src/Components/Aspire.Azure.Messaging.EventHubs/Aspire.Azure.Messaging.EventHubs.csproj Links resolver sources.
src/Components/Aspire.Azure.Data.Tables/Aspire.Azure.Data.Tables.csproj Links resolver sources.
src/Components/Aspire.Azure.AI.OpenAI/AspireConfigurableOpenAIExtensions.cs Resolves portable OpenAI keys.
src/Components/Aspire.Azure.AI.OpenAI/Aspire.Azure.AI.OpenAI.csproj Links resolver sources.
src/Components/Aspire.Azure.AI.Inference/Aspire.Azure.AI.Inference.csproj Links resolver sources.
src/Aspire.Hosting/ResourceBuilderExtensions.cs Emits aliases and validates collisions.
src/Aspire.Hosting/ApplicationModel/ConnectionStringReferenceAnnotation.cs Adds connection-reference metadata.
src/Aspire.Hosting/ApplicationModel/ConnectionStringEnvironmentVariableNames.cs Models logical and physical names.
src/Aspire.Hosting.Qdrant/QdrantBuilderExtensions.cs Normalizes supplemental HTTP references.
src/Aspire.Hosting.Kubernetes/KubernetesResource.cs Projects portable Kubernetes aliases.
src/Aspire.Hosting.EntityFrameworkCore/EFMigrationResourceBuilderExtensions.cs Uses portable migration variables.
src/Aspire.Hosting.Azure.AppService/README.md Documents App Service migration.
src/Aspire.Hosting.Azure.AppService/AzureAppServiceWebsiteContext.cs Projects portable App Service aliases.
docs/specs/connection-properties.md Documents naming and precedence.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focused review: one correctness issue.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: af599a10-84bd-4288-8f55-3e9915433275
Copilot AI review requested due to automatic review settings August 27, 2026 00:01
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: af599a10-84bd-4288-8f55-3e9915433275

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 84 out of 84 changed files in this pull request and generated no new comments.

Suppressed comments (4)

Previously missed (2) — in code that hasn't changed since the last review.

src/Aspire.Hosting/ResourceBuilderExtensions.cs:1188

  • This recovery advice is incorrect when either conflicting reference uses an explicit physical name. For example, two Application Insights references always target APPLICATIONINSIGHTS_CONNECTION_STRING; changing connectionName does not change that physical name, so following this message produces the same exception. Tailor the guidance for IsExplicit collisions so it points callers toward changing/avoiding the explicit physical-name conflict.
                throw new DistributedApplicationException(
                    $"Connection-string references '{existing.EnvironmentVariableNames.LogicalName}' and " +
                    $"'{candidate.EnvironmentVariableNames.LogicalName}' on resource '{destination.Name}' both use " +
                    $"the environment variable '{conflictingName}'. Use unique connectionName values when calling WithReference.");

src/Aspire.Hosting.Qdrant/QdrantBuilderExtensions.cs:239

  • The collision covered by the new test uses already-unique caller-supplied names (search and search_http), so telling the caller to use unique connectionName values does not explain how to resolve it. The conflict is with Qdrant's generated _http alias; identify that constraint in the message so callers know to choose names whose primary and supplemental aliases do not overlap.
                throw new DistributedApplicationException(
                    $"Connection-string references '{existing.EnvironmentVariableNames.LogicalName}' and " +
                    $"'{candidate.EnvironmentVariableNames.LogicalName}' on resource '{destination.Name}' both use " +
                    $"the environment variable '{conflictingName}'. Use unique connectionName values when calling WithReference.");

src/Aspire.Hosting.Azure.AppService/AzureAppServiceWebsiteContext.cs:78

  • This changes the deployed App Service environment contract, but the new coverage only validates the generated Bicep. It does not prove that App Service preserves ConnectionStrings__my_db at runtime or that an Aspire client registered with the logical name my-db can consume it. Please extend an App Service deployment E2E scenario with a dashed connection resource and verify the deployed workload successfully uses that client; this is the regression the PR is intended to fix.
        ProjectPortableConnectionStringAliases();

src/Aspire.Hosting.Kubernetes/KubernetesResource.cs:403

  • The Kubernetes path now changes which environment variable reaches a real pod, but the added coverage stops at Helm/YAML snapshots. It does not catch API-server validation, Helm projection, or .NET configuration binding failures after deployment. Please extend an AKS/Kubernetes deployment E2E test with a dashed connection name and verify a deployed Aspire client can use the connection.
            RemoveGeneratedLegacyConnectionStringAliases(context.EnvironmentVariables);

Copilot AI review requested due to automatic review settings August 27, 2026 00:10
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 84 out of 84 changed files in this pull request and generated no new comments.

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

src/Aspire.Hosting/ResourceBuilderExtensions.cs:1131

  • ConnectionStringExpression is mode/configuration dependent for resources such as Azure Cosmos DB and Storage. Capturing its current expression here makes the annotation stale if the source is later switched to an emulator; a subsequent reference to the same resource is then incorrectly rejected because equivalence compares the old and new strings. Use the resource's stable manifest expression (the same contract used by ConnectionStringReference) instead.
                resource.ConnectionStringExpression.ValueExpression);

src/Aspire.Hosting/ApplicationModel/ConnectionStringEnvironmentVariableNames.cs:20

  • This public constructor accepts null for all three non-nullable names and stores an invalid instance. Consumers such as the App Service projector then pass PortableName to Dictionary.ContainsKey, which throws for a null key. Add constructor validation for LogicalName, LegacyName, and PortableName (or make construction private and require Create).
public sealed record ConnectionStringEnvironmentVariableNames(
    string LogicalName,
    string LegacyName,
    string PortableName,
    bool IsExplicit)

@sebastienros

Sébastien Ros (sebastienros) commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor Author

PR #19729 Deployment Testing Report

Scope

  • Final PR head: bdf084796e
  • Product implementation tested live: 9f7a564377
  • Azure subscription: sebros dev subscription
  • Logical connection name: my-vault
  • Portable environment variable: ConnectionStrings__my_vault
  • Legacy environment variable: ConnectionStrings__my-vault
  • Test value: https://portable-alias-test.vault.azure.net/

The workload used the current Aspire.Azure.Security.KeyVault integration and called
AddAzureKeyVaultClient("my-vault"). Its endpoint injected SecretClient and returned
SecretClient.VaultUri, so a successful response proves that the updated integration
resolved the portable environment variable under the original dashed logical name.

Live deployment matrix

Target Deployment Environment variables Client integration
Docker Compose Passed Legacy and portable aliases Resolved my-vault
Azure Container Apps Passed Legacy and portable aliases Resolved my-vault
Azure App Service Passed Portable alias only Resolved my-vault
Azure Kubernetes Service Passed Portable alias only Resolved my-vault
Kubernetes Helm publisher Passed on the AKS cluster Portable alias only Resolved my-vault
Radius Passed on the AKS cluster Portable alias only Resolved my-vault
Foundry Hosted Agents Provisioning passed Portable alias only See Foundry limitation below

Docker Compose and Container Apps intentionally retain both aliases because they support
dashes. App Service, AKS/Kubernetes, Radius, and Foundry project generated connection-string
references to the portable alias only.

Foundry Hosted Agents

Foundry deployment completed successfully and created an active hosted-agent version. The
deployed version contained ConnectionStrings__my_vault with the expected value and did not
contain ConnectionStrings__my-vault.

The exact published linux/amd64 image was pulled and run locally. Its /readiness endpoint
returned HTTP 200, and its diagnostics endpoint showed:

{
  "logicalName": "my-vault",
  "vaultUri": "https://portable-alias-test.vault.azure.net/",
  "portableEnvironmentVariable": "https://portable-alias-test.vault.azure.net/",
  "legacyEnvironmentVariablePresent": false
}

Cloud invocation returned session_not_ready even after using the documented port and
readiness contract. This is consistent with the existing Foundry deployment-test blocker
tracked by #16330, so hosted-agent runtime invocation is inconclusive. The deployment payload
and locally executed deployment image both verify the connection-string behavior.

Original issue #19674

The connection-string portion of the reported stack trace is fixed. Generated references such
as ConnectionStrings__ai-light-model now have a portable alias that Foundry can deploy.

The issue also reported service-discovery variables such as
services__analytics-api__http__0. A focused reproduction against the current PR confirms
that this generated key still reaches Foundry validation and is rejected because it contains
a dash. Therefore, #19674 is not fully fixed for every environment-variable kind.

This PR should not claim that service-discovery names are normalized: changing
analytics-api to analytics_api would also change the .NET configuration key and break
lookup by the original logical service name. That requires a separate compatibility design.

Permanent coverage

The App Service and AKS deployment E2E tests now install the current Key Vault client
integration, register AddAzureKeyVaultClient("deployment-test"), inject SecretClient, and
assert its resolved URI. They no longer read deployment_test directly from configuration.
This preserves coverage of the important compatibility boundary: strict publisher emits the
portable physical key while the application continues using the original logical name.

The deployment E2E test project builds with zero warnings and errors.

Cleanup

  • Docker Compose resources removed.
  • Kubernetes Helm release and namespace removed.
  • Radius application and control plane removed.
  • Container Apps, App Service, and Foundry resource groups deleted.
  • AKS resource-group deletion initiated and monitored.
  • Port-forward processes stopped.
  • Temporary source-linked deployment harnesses removed from the worktree.

Result

Portable connection-string alias behavior is verified across all publisher targets.

Issue #19674 is only partially fixed: its connection-string failures are addressed, but
the reported dashed service-discovery environment variables remain unsupported by Foundry.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: af599a10-84bd-4288-8f55-3e9915433275
@github-actions

This comment has been minimized.

Project portable-only connection string aliases for Radius while documenting strict and capable publisher behavior. Add regression coverage for Radius, Azure Container Apps, and Docker Compose.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: af599a10-84bd-4288-8f55-3e9915433275

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 86 out of 86 changed files in this pull request and generated no new comments.

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

src/Aspire.Hosting/ResourceBuilderExtensions.cs:1188

  • The remediation is misleading for normalization collisions: my-db and my_db are already distinct connectionName values, yet this exception tells users only to make them unique. Tell users to choose names whose portable environment-variable aliases are distinct (or show the encoded aliases), so the error explains how to resolve the failure.
                throw new DistributedApplicationException(
                    $"Connection-string references '{existing.EnvironmentVariableNames.LogicalName}' and " +
                    $"'{candidate.EnvironmentVariableNames.LogicalName}' on resource '{destination.Name}' both use " +
                    $"the environment variable '{conflictingName}'. Use unique connectionName values when calling WithReference.");

src/Aspire.Hosting.Qdrant/QdrantBuilderExtensions.cs:239

  • For a primary/HTTP collision this produces references 'search_http' and 'search_http' and then recommends unique connectionName values, even though the caller used the distinct names search and search_http. Explain that each Qdrant reference reserves both the primary alias and its _http companion, and advise choosing names whose generated aliases do not overlap.
                throw new DistributedApplicationException(
                    $"Connection-string references '{existing.EnvironmentVariableNames.LogicalName}' and " +
                    $"'{candidate.EnvironmentVariableNames.LogicalName}' on resource '{destination.Name}' both use " +
                    $"the environment variable '{conflictingName}'. Use unique connectionName values when calling WithReference.");

Copilot AI review requested due to automatic review settings August 27, 2026 19:43
Use original terminology for connection-string metadata, publisher consumers, documentation, and the alias test without changing behavior.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: af599a10-84bd-4288-8f55-3e9915433275
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: af599a10-84bd-4288-8f55-3e9915433275

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Radius loses explicit logical aliases when only connection properties are injected, causing incorrect credential-provenance warnings.

Review effort: Balanced
Findings: None

Previously missed (3)

In code that hasn't changed since last review

Medium severity Preserve aliases when connection-string injection is disabled

src/​Aspire.Hosting.Radius/​Publishing/​RadiusInfrastructureBuilder.cs:3127

When connection-string injection is disabled, this annotation does not exist (ResourceBuilderExtensions only adds it under the ConnectionString flag), but connection properties are still splatted using an explicit connectionName. For example, WithReferenceEnvironment(ConnectionProperties).WithReference(sql, "admin") emits ADMIN_PASSWORD, while this method records only the relationship fallback SQL_; Radius then misclassifies the genuine injected credential as unrelated and can emit ASPIRERADIUS070. Preserve the logical alias independently of connection-string emission (without re-enabling collision checks for suppressed strings), and cover this flags-plus-alias case.

Low severity Document double-underscore normalization in portable aliases

src/​Aspire.Hosting/​ResourceBuilderExtensions.cs:1092

The portable alias is also generated when the logical name contains __, even though underscores are valid environment-variable characters, because __ would become a nested configuration delimiter. As written, the public documentation incorrectly describes only unsupported-character replacement and omits this observable normalization (for example, db__primary becomes db_primary).

Low severity Document explicit connection-string environment variable collision handling

src/​Aspire.Hosting/​ResourceBuilderExtensions.cs:1192

This guidance cannot resolve collisions involving an explicit IResourceWithConnectionString.ConnectionStringEnvironmentVariable: Create deliberately ignores connectionName and preserves that physical name. Emit guidance that tells users to change the explicit physical name when applicable (or distinguish explicit from generated aliases), rather than always recommending connectionName.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Properties-only aliased Radius references lose required logical metadata, and the new runtime package dependency is missing from conditional-test routing.

Review effort: Balanced
Findings: None

Previously missed (2)

In code that hasn't changed since last review

Medium severity Preserve logical reference metadata without connection-string injection

src/​Aspire.Hosting/​ResourceBuilderExtensions.cs:1129

Recording this metadata only when the connection string itself is injected loses the custom logical name for properties-only references. Radius now derives connection-property provenance from this annotation; with .WithReferenceEnvironment(ConnectionProperties).WithReference(sql, "admin"), no annotation is added, the relationship fallback records sql, and the generated ADMIN_PASSWORD is incorrectly reported as an unrelated credential use (ASPIRERADIUS070). Preserve the logical reference metadata even when connection-string injection is disabled, while keeping physical-name collision validation limited to references that actually inject connection strings.

Medium severity Add Key Vault package to deployment E2E trigger mapping

tests/​Aspire.Deployment.EndToEnd.Tests/​AksStarterDeploymentTests.cs:183

This adds Aspire.Azure.Security.KeyVault as a runtime-only dependency of this deployment scenario (and the App Service scenario), but eng/github-ci/test-trigger-map.yml routes only Aspire.Hosting.Azure* and related projects to job:deployment-e2e. Changes to the Key Vault client package therefore won't report this advisory deployment coverage. Add Aspire.Azure.Security.KeyVault to the deployment E2E affected-project rule and cover the edge in TestTriggerMapTests.

@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: af599a10-84bd-4288-8f55-3e9915433275

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Radius misclassifies connection-property prefixes under selective injection flags, and the new public factory lacks required exception documentation.

Review effort: Balanced
Findings: None

Previously missed (2)

In code that hasn't changed since last review

Medium severity Track connection-property injection separately from connection-string references

src/​Aspire.Hosting.Radius/​Publishing/​RadiusInfrastructureBuilder.cs:3129

ConnectionStringReference metadata tracks connection-string injection, not connection-property injection, so it cannot reliably identify splat prefixes here. With ConnectionString only, this records the logical prefix even though no properties were emitted and can suppress ASPIRERADIUS070 for a user-authored <LOGICAL>_PASSWORD; with ConnectionProperties only, no reference annotation is added, so an aliased property such as ADMIN_PASSWORD is incorrectly reported as unrelated. Persist dedicated connection-property injection metadata (including the logical name and flags) and build these prefixes only from references that actually splatted properties.

Low severity Document ArgumentNullException in the public method XML docs

src/​Aspire.Hosting/​ApplicationModel/​ConnectionStringEnvironmentVariableNames.cs:65

This new public method throws ArgumentNullException for both parameters, but its XML documentation omits that contract. Public APIs under src/ must document thrown exceptions; add an <exception> entry naming both parameters.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: af599a10-84bd-4288-8f55-3e9915433275
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Moderate deployment-E2E routing gaps and lost starter endpoint coverage remain unresolved.

Review effort: Balanced
Findings: None

Previously missed (3)

In code that hasn't changed since last review

Medium severity Route Key Vault package changes to deployment E2E tests

tests/​Aspire.Deployment.EndToEnd.Tests/​AksStarterDeploymentTests.cs:183

This adds a runtime-only dependency on the repository-built Aspire.Azure.Security.KeyVault package, but eng/github-ci/test-trigger-map.yml has no rule routing changes to that component to job:deployment-e2e (the existing rule covers Aspire.Hosting.Azure*, not Aspire.Azure.*). A future change to this package can therefore skip the deployment scenario that now validates portable aliases; add the package to the deployment E2E affected-project/path routing and its focused map coverage.

Medium severity Route Key Vault package changes to deployment E2E tests

tests/​Aspire.Deployment.EndToEnd.Tests/​AppServiceReactDeploymentTests.cs:112

This adds a runtime-only dependency on the repository-built Aspire.Azure.Security.KeyVault package, but eng/github-ci/test-trigger-map.yml has no rule routing changes to that component to job:deployment-e2e (the existing rule covers Aspire.Hosting.Azure*, not Aspire.Azure.*). A future change to this package can therefore skip the deployment scenario that now validates portable aliases; add the package to the deployment E2E affected-project/path routing and its focused map coverage.

Low severity Document OriginalName behavior for explicit physical overrides

src/​Aspire.Hosting/​ApplicationModel/​ConnectionStringEnvironmentVariableNames.cs:30

OriginalName is documented as derived directly from logicalName, but Create returns resource.ConnectionStringEnvironmentVariable when an explicit physical override exists and assigns that value to both names. The public metadata is therefore misleading for explicit resources; document that exception here as well.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: af599a10-84bd-4288-8f55-3e9915433275
@github-actions

Copy link
Copy Markdown
Contributor

Tests selector

87 / 99 PR test projects · 4 PR jobs, from 102 changed files.

Selected PR test projects (87 / 99)

Aspire.Azure.AI.Inference.Tests, Aspire.Azure.AI.OpenAI.Tests, Aspire.Azure.Data.Tables.Tests, Aspire.Azure.Messaging.EventHubs.Tests, Aspire.Azure.Messaging.ServiceBus.Tests, Aspire.Azure.Messaging.WebPubSub.Tests, Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL.Tests, Aspire.Azure.Npgsql.Tests, Aspire.Azure.Search.Documents.Tests, Aspire.Azure.Security.KeyVault.Tests, Aspire.Azure.Storage.Blobs.Tests, Aspire.Azure.Storage.Files.DataLake.Tests, Aspire.Azure.Storage.Queues.Tests, Aspire.Cli.EndToEnd.Tests, Aspire.Confluent.Kafka.Tests, Aspire.Hosting.Analyzers.Tests, Aspire.Hosting.Azure.Kubernetes.Tests, Aspire.Hosting.Azure.Kusto.Tests, Aspire.Hosting.Azure.Provisioning.Tests, Aspire.Hosting.Azure.Tests, Aspire.Hosting.Blazor.Tests, Aspire.Hosting.Browsers.Tests, Aspire.Hosting.CodeGeneration.Go.Tests, Aspire.Hosting.CodeGeneration.Java.Tests, Aspire.Hosting.CodeGeneration.Python.Tests, Aspire.Hosting.CodeGeneration.Rust.Tests, Aspire.Hosting.CodeGeneration.TypeScript.Tests, Aspire.Hosting.Containers.Tests, Aspire.Hosting.DevTunnels.Tests, Aspire.Hosting.Docker.Tests, Aspire.Hosting.Dotnet.Tests, Aspire.Hosting.DotnetTool.Tests, Aspire.Hosting.EntityFrameworkCore.Tests, Aspire.Hosting.Foundry.Tests, Aspire.Hosting.Garnet.Tests, Aspire.Hosting.Go.Tests, Aspire.Hosting.Java.Tests, Aspire.Hosting.JavaScript.Tests, Aspire.Hosting.Kafka.Tests, Aspire.Hosting.Keycloak.Tests, Aspire.Hosting.Kubernetes.Tests, Aspire.Hosting.Maui.Tests, Aspire.Hosting.Milvus.Tests, Aspire.Hosting.MongoDB.Tests, Aspire.Hosting.MySql.Tests, Aspire.Hosting.Nats.Tests, Aspire.Hosting.OpenAI.Tests, Aspire.Hosting.Oracle.Tests, Aspire.Hosting.Orleans.Tests, Aspire.Hosting.PostgreSQL.Tests, Aspire.Hosting.Python.Tests, Aspire.Hosting.Qdrant.Tests, Aspire.Hosting.RabbitMQ.Tests, Aspire.Hosting.Radius.Tests, Aspire.Hosting.Redis.Tests, Aspire.Hosting.RemoteHost.Tests, Aspire.Hosting.Rust.Tests, Aspire.Hosting.Seq.Tests, Aspire.Hosting.SqlServer.Tests, Aspire.Hosting.Testing.Tests, Aspire.Hosting.Tests, Aspire.Hosting.Valkey.Tests, Aspire.Hosting.Yarp.Tests, Aspire.Microsoft.Azure.Cosmos.Tests, Aspire.Microsoft.Azure.StackExchangeRedis.Tests, Aspire.Microsoft.Data.SqlClient.Tests, Aspire.Microsoft.EntityFrameworkCore.Cosmos.Tests, Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests, Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration.Tests, Aspire.Milvus.Client.Tests, Aspire.MongoDB.Driver.Tests, Aspire.MongoDB.Driver.v2.Tests, Aspire.MongoDB.EntityFrameworkCore.Tests, Aspire.MySqlConnector.Tests, Aspire.NATS.Net.Tests, Aspire.Npgsql.EntityFrameworkCore.PostgreSQL.Tests, Aspire.Npgsql.Tests, Aspire.OpenAI.Tests, Aspire.Playground.Tests, Aspire.Pomelo.EntityFrameworkCore.MySql.Tests, Aspire.Qdrant.Client.Tests, Aspire.RabbitMQ.Client.Tests, Aspire.RabbitMQ.Client.v6.Tests, Aspire.Seq.Tests, Aspire.StackExchange.Redis.DistributedCaching.Tests, Aspire.StackExchange.Redis.OutputCaching.Tests, Aspire.StackExchange.Redis.Tests

Selected PR jobs (4)

cli-starter-validation, extension-e2e, polyglot, typescript-api-compat


How these were chosen — grouped by what changed

⚠️ 21 of the 87 selected test projects come from a single change — src/Aspire.Hosting/ApplicationModel/ConnectionStringEnvironmentVariableNames.cs.

🔧 src/Aspire.Hosting/ApplicationModel/ConnectionStringEnvironmentVariableNames.cs (changed source)
→ 21 via the project graph

show 21

Aspire.Hosting.Analyzers.Tests (2 hops), Aspire.Hosting.Browsers.Tests (2 hops), Aspire.Hosting.CodeGeneration.Go.Tests, Aspire.Hosting.CodeGeneration.Java.Tests, Aspire.Hosting.CodeGeneration.Python.Tests, Aspire.Hosting.CodeGeneration.Rust.Tests, Aspire.Hosting.Containers.Tests (2 hops), Aspire.Hosting.DotnetTool.Tests (2 hops), Aspire.Hosting.Go.Tests (2 hops), Aspire.Hosting.Java.Tests (2 hops), Aspire.Hosting.JavaScript.Tests (2 hops), Aspire.Hosting.Keycloak.Tests (2 hops), Aspire.Hosting.Maui.Tests, Aspire.Hosting.OpenAI.Tests (2 hops), Aspire.Hosting.Orleans.Tests (2 hops), Aspire.Hosting.Python.Tests (2 hops), Aspire.Hosting.RemoteHost.Tests, Aspire.Hosting.Rust.Tests (2 hops), Aspire.Hosting.Seq.Tests (2 hops), Aspire.Hosting.Testing.Tests (2 hops), Aspire.Playground.Tests

🔧 src/Components/Aspire.StackExchange.Redis/Aspire.StackExchange.Redis.csproj (changed source)
→ 1 directly: Aspire.StackExchange.Redis.Tests
→ 6 via the project graph: Aspire.Hosting.Garnet.Tests, Aspire.Hosting.Redis.Tests, Aspire.Hosting.Valkey.Tests, Aspire.Microsoft.Azure.StackExchangeRedis.Tests (2 hops), Aspire.StackExchange.Redis.DistributedCaching.Tests (2 hops), Aspire.StackExchange.Redis.OutputCaching.Tests (2 hops)

🔧 src/Aspire.Hosting.Azure/AzurePublishingContext.cs (changed source)
→ 1 directly: Aspire.Hosting.Azure.Tests
→ 2 via the project graph: Aspire.Hosting.Azure.Kusto.Tests (2 hops), Aspire.Hosting.Azure.Provisioning.Tests (2 hops)

🔧 src/Components/Aspire.Npgsql/Aspire.Npgsql.csproj (changed source)
→ 1 directly: Aspire.Npgsql.Tests
→ 2 via the project graph: Aspire.Azure.Npgsql.Tests (2 hops), Aspire.Hosting.PostgreSQL.Tests

🧪 tests/Aspire.Hosting.Tests/WithReferenceTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests
→ 2 via the project graph: Aspire.Hosting.Blazor.Tests, Aspire.Hosting.Dotnet.Tests

🔧 src/Aspire.Hosting.Azure.AppContainers/BaseContainerAppContext.cs (changed source)
→ 1 directly: Aspire.Hosting.Azure.Tests
→ 1 via the project graph: Aspire.Hosting.CodeGeneration.TypeScript.Tests

🔧 src/Aspire.Hosting.Docker/DockerComposeServiceResourceExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.Docker.Tests
→ 1 via the project graph: Aspire.Hosting.Yarp.Tests

🔧 src/Components/Aspire.Confluent.Kafka/Aspire.Confluent.Kafka.csproj (changed source)
→ 1 directly: Aspire.Confluent.Kafka.Tests
→ 1 via the project graph: Aspire.Hosting.Kafka.Tests

🔧 src/Components/Aspire.Microsoft.Data.SqlClient/Aspire.Microsoft.Data.SqlClient.csproj (changed source)
→ 1 directly: Aspire.Microsoft.Data.SqlClient.Tests
→ 1 via the project graph: Aspire.Hosting.SqlServer.Tests

🔧 src/Components/Aspire.MongoDB.Driver/Aspire.MongoDB.Driver.csproj (changed source)
→ 1 directly: Aspire.MongoDB.Driver.Tests
→ 1 via the project graph: Aspire.Hosting.MongoDB.Tests

🔧 src/Components/Aspire.MySqlConnector/Aspire.MySqlConnector.csproj (changed source)
→ 1 directly: Aspire.MySqlConnector.Tests
→ 1 via the project graph: Aspire.Hosting.MySql.Tests

🔧 src/Components/Aspire.NATS.Net/Aspire.NATS.Net.csproj (changed source)
→ 1 directly: Aspire.NATS.Net.Tests
→ 1 via the project graph: Aspire.Hosting.Nats.Tests

🔧 src/Components/Aspire.Npgsql.EntityFrameworkCore.PostgreSQL/Aspire.Npgsql.EntityFrameworkCore.PostgreSQL.csproj (changed source)
→ 1 directly: Aspire.Npgsql.EntityFrameworkCore.PostgreSQL.Tests
→ 1 via the project graph: Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL.Tests (2 hops)

🔧 src/Components/Aspire.RabbitMQ.Client/Aspire.RabbitMQ.Client.csproj (changed source)
→ 1 directly: Aspire.RabbitMQ.Client.Tests
→ 1 via the project graph: Aspire.Hosting.RabbitMQ.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/AzureAppServiceTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests
→ 1 via the project graph: Aspire.Hosting.Azure.Kubernetes.Tests

📦 affected project Aspire.Hosting.Docker
→ 1 test: Aspire.Cli.EndToEnd.Tests

🔧 src/Aspire.Hosting.Azure.AppService/AzureAppServiceWebsiteContext.cs (changed source)
→ 1 directly: Aspire.Hosting.Azure.Tests

🔧 src/Aspire.Hosting.EntityFrameworkCore/EFMigrationResourceBuilderExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.EntityFrameworkCore.Tests

🔧 src/Aspire.Hosting.Foundry/HostedAgent/AzureHostedAgentResource.cs (changed source)
→ 1 directly: Aspire.Hosting.Foundry.Tests

🔧 src/Aspire.Hosting.Kubernetes/KubernetesResource.cs (changed source)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🔧 src/Aspire.Hosting.Qdrant/QdrantBuilderExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.Qdrant.Tests

🔧 src/Aspire.Hosting.Radius/Publishing/RadiusInfrastructureBuilder.cs (changed source)
→ 1 directly: Aspire.Hosting.Radius.Tests

🔧 src/Components/Aspire.Azure.AI.Inference/Aspire.Azure.AI.Inference.csproj (changed source)
→ 1 directly: Aspire.Azure.AI.Inference.Tests

🔧 src/Components/Aspire.Azure.AI.OpenAI/Aspire.Azure.AI.OpenAI.csproj (changed source)
→ 1 directly: Aspire.Azure.AI.OpenAI.Tests

🔧 src/Components/Aspire.Azure.AI.OpenAI/AspireConfigurableOpenAIExtensions.cs (changed source)
→ 1 directly: Aspire.Azure.AI.OpenAI.Tests

🔧 src/Components/Aspire.Azure.Data.Tables/Aspire.Azure.Data.Tables.csproj (changed source)
→ 1 directly: Aspire.Azure.Data.Tables.Tests

🔧 src/Components/Aspire.Azure.Messaging.EventHubs/Aspire.Azure.Messaging.EventHubs.csproj (changed source)
→ 1 directly: Aspire.Azure.Messaging.EventHubs.Tests

🔧 src/Components/Aspire.Azure.Messaging.ServiceBus/Aspire.Azure.Messaging.ServiceBus.csproj (changed source)
→ 1 directly: Aspire.Azure.Messaging.ServiceBus.Tests

🔧 src/Components/Aspire.Azure.Messaging.WebPubSub/Aspire.Azure.Messaging.WebPubSub.csproj (changed source)
→ 1 directly: Aspire.Azure.Messaging.WebPubSub.Tests

🔧 src/Components/Aspire.Azure.Search.Documents/Aspire.Azure.Search.Documents.csproj (changed source)
→ 1 directly: Aspire.Azure.Search.Documents.Tests

🔧 src/Components/Aspire.Azure.Security.KeyVault/Aspire.Azure.Security.KeyVault.csproj (changed source)
→ 1 directly: Aspire.Azure.Security.KeyVault.Tests

🔧 src/Components/Aspire.Azure.Security.KeyVault/AspireKeyVaultExtensions.cs (changed source)
→ 1 directly: Aspire.Azure.Security.KeyVault.Tests

🔧 src/Components/Aspire.Azure.Storage.Blobs/Aspire.Azure.Storage.Blobs.csproj (changed source)
→ 1 directly: Aspire.Azure.Storage.Blobs.Tests

🔧 src/Components/Aspire.Azure.Storage.Files.DataLake/Aspire.Azure.Storage.Files.DataLake.csproj (changed source)
→ 1 directly: Aspire.Azure.Storage.Files.DataLake.Tests

🔧 src/Components/Aspire.Azure.Storage.Queues/Aspire.Azure.Storage.Queues.csproj (changed source)
→ 1 directly: Aspire.Azure.Storage.Queues.Tests

🔧 src/Components/Aspire.Confluent.Kafka/AspireKafkaConsumerExtensions.cs (changed source)
→ 1 directly: Aspire.Confluent.Kafka.Tests

🔧 src/Components/Aspire.Confluent.Kafka/AspireKafkaProducerExtensions.cs (changed source)
→ 1 directly: Aspire.Confluent.Kafka.Tests

🔧 src/Components/Aspire.Microsoft.Azure.Cosmos/Aspire.Microsoft.Azure.Cosmos.csproj (changed source)
→ 1 directly: Aspire.Microsoft.Azure.Cosmos.Tests

🔧 src/Components/Aspire.Microsoft.Azure.Cosmos/AspireMicrosoftAzureCosmosExtensions.cs (changed source)
→ 1 directly: Aspire.Microsoft.Azure.Cosmos.Tests

🔧 src/Components/Aspire.Microsoft.Data.SqlClient/AspireSqlServerSqlClientExtensions.cs (changed source)
→ 1 directly: Aspire.Microsoft.Data.SqlClient.Tests

🔧 src/Components/Aspire.Microsoft.EntityFrameworkCore.Cosmos/Aspire.Microsoft.EntityFrameworkCore.Cosmos.csproj (changed source)
→ 1 directly: Aspire.Microsoft.EntityFrameworkCore.Cosmos.Tests

🔧 src/Components/Aspire.Microsoft.EntityFrameworkCore.Cosmos/AspireAzureEFCoreCosmosExtensions.cs (changed source)
→ 1 directly: Aspire.Microsoft.EntityFrameworkCore.Cosmos.Tests

🔧 src/Components/Aspire.Microsoft.EntityFrameworkCore.SqlServer/Aspire.Microsoft.EntityFrameworkCore.SqlServer.csproj (changed source)
→ 1 directly: Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests

🔧 src/Components/Aspire.Microsoft.EntityFrameworkCore.SqlServer/AspireSqlServerEFCoreSqlClientExtensions.cs (changed source)
→ 1 directly: Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests

🔧 src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration.csproj (changed source)
→ 1 directly: Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration.Tests

🔧 src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/AspireAppConfigurationExtensions.cs (changed source)
→ 1 directly: Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration.Tests

🔧 src/Components/Aspire.Milvus.Client/Aspire.Milvus.Client.csproj (changed source)
→ 1 directly: Aspire.Milvus.Client.Tests

🔧 src/Components/Aspire.Milvus.Client/AspireMilvusExtensions.cs (changed source)
→ 1 directly: Aspire.Milvus.Client.Tests

🔧 src/Components/Aspire.MongoDB.Driver.v2/Aspire.MongoDB.Driver.v2.csproj (changed source)
→ 1 directly: Aspire.MongoDB.Driver.v2.Tests

🔧 src/Components/Aspire.MongoDB.Driver/AspireMongoDBDriverExtensions.cs (changed source)
→ 1 directly: Aspire.MongoDB.Driver.Tests

🔧 src/Components/Aspire.MongoDB.EntityFrameworkCore/Aspire.MongoDB.EntityFrameworkCore.csproj (changed source)
→ 1 directly: Aspire.MongoDB.EntityFrameworkCore.Tests

🔧 src/Components/Aspire.MongoDB.EntityFrameworkCore/AspireMongoDBEntityFrameworkCoreExtensions.cs (changed source)
→ 1 directly: Aspire.MongoDB.EntityFrameworkCore.Tests

🔧 src/Components/Aspire.MySqlConnector/AspireMySqlConnectorExtensions.cs (changed source)
→ 1 directly: Aspire.MySqlConnector.Tests

🔧 src/Components/Aspire.NATS.Net/AspireNatsClientExtensions.cs (changed source)
→ 1 directly: Aspire.NATS.Net.Tests

🔧 src/Components/Aspire.Npgsql.EntityFrameworkCore.PostgreSQL/AspireEFPostgreSqlExtensions.cs (changed source)
→ 1 directly: Aspire.Npgsql.EntityFrameworkCore.PostgreSQL.Tests

🔧 src/Components/Aspire.Npgsql/AspirePostgreSqlNpgsqlExtensions.cs (changed source)
→ 1 directly: Aspire.Npgsql.Tests

🔧 src/Components/Aspire.OpenAI/Aspire.OpenAI.csproj (changed source)
→ 1 directly: Aspire.OpenAI.Tests

🔧 src/Components/Aspire.OpenAI/AspireOpenAIClientBuilder.cs (changed source)
→ 1 directly: Aspire.OpenAI.Tests

🔧 src/Components/Aspire.OpenAI/AspireOpenAIExtensions.cs (changed source)
→ 1 directly: Aspire.OpenAI.Tests

🔧 src/Components/Aspire.Oracle.EntityFrameworkCore/Aspire.Oracle.EntityFrameworkCore.csproj (changed source)
→ 1 via the project graph: Aspire.Hosting.Oracle.Tests

🔧 src/Components/Aspire.Pomelo.EntityFrameworkCore.MySql/Aspire.Pomelo.EntityFrameworkCore.MySql.csproj (changed source)
→ 1 directly: Aspire.Pomelo.EntityFrameworkCore.MySql.Tests

🔧 src/Components/Aspire.Pomelo.EntityFrameworkCore.MySql/AspireEFMySqlExtensions.cs (changed source)
→ 1 directly: Aspire.Pomelo.EntityFrameworkCore.MySql.Tests

🔧 src/Components/Aspire.Qdrant.Client/Aspire.Qdrant.Client.csproj (changed source)
→ 1 directly: Aspire.Qdrant.Client.Tests

🔧 src/Components/Aspire.Qdrant.Client/AspireQdrantExtensions.cs (changed source)
→ 1 directly: Aspire.Qdrant.Client.Tests

🔧 src/Components/Aspire.RabbitMQ.Client.v6/Aspire.RabbitMQ.Client.v6.csproj (changed source)
→ 1 directly: Aspire.RabbitMQ.Client.v6.Tests

🔧 src/Components/Aspire.RabbitMQ.Client/AspireRabbitMQExtensions.cs (changed source)
→ 1 directly: Aspire.RabbitMQ.Client.Tests

🔧 src/Components/Aspire.Seq/Aspire.Seq.csproj (changed source)
→ 1 directly: Aspire.Seq.Tests

🔧 src/Components/Aspire.Seq/AspireSeqExtensions.cs (changed source)
→ 1 directly: Aspire.Seq.Tests

🔧 src/Components/Aspire.StackExchange.Redis/AspireRedisExtensions.cs (changed source)
→ 1 directly: Aspire.StackExchange.Redis.Tests

🔧 src/Components/Common/ConnectionStringConfigurationExtensions.cs (changed source)
→ 1 via the project graph: Aspire.Microsoft.Data.SqlClient.Tests

🔧 src/Shared/EnvironmentVariableNameEncoder.cs (changed source)
→ 1 via the project graph: Aspire.Hosting.DevTunnels.Tests

🧪 tests/Aspire.Azure.Security.KeyVault.Tests/AspireKeyVaultExtensionsTests.cs (changed test)
→ 1 directly: Aspire.Azure.Security.KeyVault.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/AzureContainerAppsTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/FoundryExtensionsTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/Snapshots/AzureAppServiceTests.PublishToAppService_WithDashedConnectionStringName_UsesPortableAlias.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests

🧪 tests/Aspire.Hosting.Docker.Tests/DockerComposePublisherTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Docker.Tests

🧪 tests/Aspire.Hosting.EntityFrameworkCore.Tests/EFMigrationPipelineTests.cs (changed test)
→ 1 directly: Aspire.Hosting.EntityFrameworkCore.Tests

🧪 tests/Aspire.Hosting.Foundry.Tests/HostedAgentExtensionTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Foundry.Tests

🧪 tests/Aspire.Hosting.Foundry.Tests/ToolboxTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Foundry.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/KubernetesPublisherTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_HandlesSpecialResourceName#01.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_HandlesSpecialResourceName#05.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_HandlesSpecialResourceName#06.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Milvus.Tests/AddMilvusTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Milvus.Tests

🧪 tests/Aspire.Hosting.Qdrant.Tests/AddQdrantTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Qdrant.Tests

🧪 tests/Aspire.Hosting.Qdrant.Tests/Snapshots/AddQdrantTests.RepeatedReferencesPreserveDistinctConnectionExpressions.verified.txt (changed test)
→ 1 directly: Aspire.Hosting.Qdrant.Tests

🧪 tests/Aspire.Hosting.Radius.Tests/Publishing/BackingResourceValueResolutionTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Radius.Tests

🧪 tests/Aspire.Hosting.Radius.Tests/Publishing/ConnectionStringPropagationTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Radius.Tests

🧪 tests/Aspire.Hosting.Radius.Tests/Snapshots/BackingResourceValueResolutionTests.NestedConnectionName_PreservesLogicalPropertyPrefixes.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Radius.Tests

🧪 tests/Aspire.Hosting.Radius.Tests/Snapshots/BackingResourceValueResolutionTests.NestedConnectionName_UserAuthoredPortablePrefix_IsReportedAsAnUnrelatedUse.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Radius.Tests

🧪 tests/Aspire.Microsoft.Data.SqlClient.Tests/Aspire.Microsoft.Data.SqlClient.Tests.csproj (changed test)
→ 1 directly: Aspire.Microsoft.Data.SqlClient.Tests

🧪 tests/Aspire.Microsoft.Data.SqlClient.Tests/AspireSqlServerSqlClientExtensionsTests.cs (changed test)
→ 1 directly: Aspire.Microsoft.Data.SqlClient.Tests

🧪 tests/Aspire.Microsoft.Data.SqlClient.Tests/ConnectionStringConfigurationExtensionsTests.cs (changed test)
→ 1 directly: Aspire.Microsoft.Data.SqlClient.Tests

Job reasons

Job Triggered by
cli-starter-validation affected project Aspire.Hosting.JavaScript
extension-e2e • src/Aspire.Hosting.Docker/DockerComposeServiceResourceExtensions.cs, src/Aspire.Hosting/ApplicationModel/ConnectionStringEnvironmentVariableNames.cs, src/Aspire.Hosting/ApplicationModel/ConnectionStringReference.cs, src/Aspire.Hosting/ApplicationModel/ExpressionResolver.cs, src/Aspire.Hosting/Aspire.Hosting.csproj, src/Aspire.Hosting/ResourceBuilderExtensions.cs
• affected project Aspire.Hosting.Docker
polyglot • affected project Aspire.Hosting.Azure.AppContainers
• affected project Aspire.Hosting.Azure.Provisioning.AppContainers
typescript-api-compat affected project Aspire.Hosting.Azure.AppContainers

Selection computed for commit 13b0af1.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Moderate issues remain in strict-target alias projection and Hosting portable-key resolution.

Review effort: Balanced
Findings: None

@sebastienros

Copy link
Copy Markdown
Contributor Author

Documentation has been drafted in microsoft/aspire.dev#1778, targeting release/13.6.

The release notes already cover portable aliases and migration. The canonical environment-variable guide still claimed connection-string names were never encoded and showed original-only lookups. This draft fixes that one page; it doesn't duplicate the release notes or modify the open release rollup, microsoft/aspire.dev#1599.

docs_required, no exclusion. All four signals are addressed: experimental_attribute_added (ASPIRECONNECTIONSTRINGS001 on the naming record/property); new_public_type (ConnectionStringEnvironmentVariableNames); integration_readme_changed (App Service physical-name exceptions and Radius property-prefix distinction); and pr_body_has_user_facing_section (logical/portable names and migration). The guide now covers strict targets, encoding, collisions, explicit overrides, logical-first configuration fallback, and experimental custom-publisher metadata.

The target is an exact match for milestone 13.6. No feature-specific duplicate was found. Rendering, anchors, and changed consumer examples were checked locally.

Note

Human review is required before merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants