Skip to content

Enable dapr tests on CI#5416

Closed
radical wants to merge 6 commits intomicrosoft:mainfrom
radical:dapr-ci
Closed

Enable dapr tests on CI#5416
radical wants to merge 6 commits intomicrosoft:mainfrom
radical:dapr-ci

Conversation

@radical
Copy link
Member

@radical radical commented Aug 24, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 24, 2024
@radical radical added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️ and removed area-integrations Issues pertaining to Aspire Integrations packages labels Aug 24, 2024
@radical
Copy link
Member Author

radical commented Aug 24, 2024

2024-08-24T01:16:52.9380000
stderr Flag --dapr-http-max-request-size has been deprecated, use '--max-body-size 4Mi'
10
2024-08-24T01:16:52.9380000
stderr Flag --dapr-http-read-buffer-size has been deprecated, use '--read-buffer-size 4Ki'

@radical
Copy link
Member Author

radical commented Aug 28, 2024

Blocked on:
info: Dapr.AppHost.Resources.serviceb-dapr-cli[0] 20: 2024-08-24T06:14:39.720Z time="2024-08-24T06:14:39.720428416Z" level=error msg="Failed to init component pubsub (pubsub.redis/v1): [INIT_COMPONENT_FAILURE]: initialization error occurred for pubsub (pubsub.redis/v1): redis streams: error connecting to redis at localhost:6379: dial tcp 127.0.0.1:6379: connect: connection refused" app_id=serviceb instance=a006G8Q scope=dapr.runtime.processor type=log ver=1.14.1

info: Dapr.AppHost.Resources.serviceb-dapr-cli[0] 21: 2024-08-24T06:14:39.720Z time="2024-08-24T06:14:39.72048222Z" level=warning msg="Error processing component, daprd will exit gracefully: process component pubsub error: [INIT_COMPONENT_FAILURE]: initialization error occurred for pubsub (pubsub.redis/v1): [INIT_COMPONENT_FAILURE]: initialization error occurred for pubsub (pubsub.redis/v1): redis streams: error connecting to redis at localhost:6379: dial tcp 127.0.0.1:6379: connect: connection refused" app_id=serviceb instance=a006G8Q scope=dapr.runtime.processor type=log ver=1.14.1

This seems to be starting dapr before redis is ready for connections. The order probably be enforced with #5394 .

@@ -1,5 +1,6 @@
var builder = DistributedApplication.CreateBuilder(args);

var redis = builder.AddRedis("redis", 6379);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dapr CLI usually spins this up.

@davidfowl davidfowl added dapr area-integrations Issues pertaining to Aspire Integrations packages and removed area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication labels Sep 15, 2024
@davidfowl
Copy link
Contributor

We should be able to use waitfor to make these tests work now.

@radical radical mentioned this pull request Sep 17, 2024
35 tasks
@davidfowl
Copy link
Contributor

Dapr is moving to the toolkit

@davidfowl davidfowl closed this Jan 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages blocked dapr testing ☑️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants