[release/9.0-rc1] Improve the experience when docker isn't running#6157
Merged
joperezr merged 2 commits intorelease/9.0-rc1from Oct 7, 2024
Merged
[release/9.0-rc1] Improve the experience when docker isn't running#6157joperezr merged 2 commits intorelease/9.0-rc1from
joperezr merged 2 commits intorelease/9.0-rc1from
Conversation
… runtime isn't running, log a critical error but continue running and sending requests to dcp. DCP will wait for the container runtime to be healthy (started) and will run the containers.
…. - Improve the error message for docker and podman.
joperezr
approved these changes
Oct 7, 2024
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
Low-risk, addressing top feedback item. Approved.
github-actions
bot
added
the
area-app-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6135 to release/9.0-rc1
/cc @davidfowl
Customer Impact
We're shipping a new experience that we want customers to give feedback on WRT one of the most common issues people hit when using aspire when the container runtime ins't running, or is in a incompatible state (resource saver mode).
Testing
Manual
Risk
Low
Regression?
No
Microsoft Reviewers: Open in CodeFlow