Use ResourceReadyEvent to avoid blocking startup importing redis databases#6308
Merged
Use ResourceReadyEvent to avoid blocking startup importing redis databases#6308
Conversation
- Fixed test after changes
16 tasks
Member
|
Good technique for jumping across to a non-blocking event. LGTM. |
mitchdenny
approved these changes
Oct 15, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #6141
Description
This pull request focuses on ensuring that all endpoints are allocated before attempting to import databases in Redis-related operations. It introduces a mechanism to wait for the allocation of endpoints and modifies the test to verify this behavior.
Improvements to Redis resource handling:
src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs: Added aTaskCompletionSourceto wait for all endpoints to be allocated before importing databases. Subscribed toAfterEndpointsAllocatedEventto signal when endpoints are ready. [1] [2]Test updates:
tests/Aspire.Hosting.Redis.Tests/RedisFunctionalTests.cs: Modified the test to use aTaskCompletionSourceto wait for theResourceReadyEventinstead of directly waiting for the resource state to be running. This ensures that the database import process is verified correctly.Fixes #6136
Fixes #6099
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow