[release/9.2] Fixed resolving secrets for keyvault references in run mode#8755
Merged
davidfowl merged 2 commits intorelease/9.2from Apr 18, 2025
Merged
[release/9.2] Fixed resolving secrets for keyvault references in run mode#8755davidfowl merged 2 commits intorelease/9.2from
davidfowl merged 2 commits intorelease/9.2from
Conversation
…ken credential resolution out of the AzureProvisioner so it can shared. - Configure the secret resolving in both configure and provision cases.
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
eerhardt
reviewed
Apr 14, 2025
eerhardt
reviewed
Apr 14, 2025
src/Aspire.Hosting.Azure/Provisioning/Provisioners/TokenCredentialHolder.cs
Outdated
Show resolved
Hide resolved
eerhardt
approved these changes
Apr 14, 2025
davidfowl
reviewed
Apr 15, 2025
src/Aspire.Hosting.Azure/Provisioning/Provisioners/TokenCredentialHolder.cs
Outdated
Show resolved
Hide resolved
mitchdenny
approved these changes
Apr 15, 2025
1 task
danmoseley
added
area-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8751 to release/9.2
/cc @davidfowl
Customer Impact
The new first class key vault secret reference feature does not work in run mode after the first run. This makes it impossible to move away from bicep secret outputs in your own resources or use any of our resources with key references in run mode.
Testing
Manul on the customer's repro.
Risk
Low
Regression?
Yes.