[Bug 1859080] Fix the bug of reporting error in azure explorer before sign in#5579
Merged
[Bug 1859080] Fix the bug of reporting error in azure explorer before sign in#5579
Conversation
shenqianjin
reviewed
Jul 22, 2021
...rer-common/src/com/microsoft/tooling/msservices/serviceexplorer/azure/mysql/MySQLModule.java
Outdated
Show resolved
Hide resolved
shenqianjin
previously approved these changes
Jul 22, 2021
andxu
force-pushed
the
feature-explorer-signin
branch
from
79db564 to
1d35293
Compare
...-explorer-common/src/com/microsoft/tooling/msservices/serviceexplorer/azure/AzureModule.java
Outdated
Show resolved
Hide resolved
andxu
force-pushed
the
feature-explorer-signin
branch
from
1d35293 to
1fa7825
Compare
| if (AuthMethodManager.getInstance().isSignedIn() || this instanceof AzureModule) { | ||
| refreshItems(); | ||
| } | ||
| refreshItems(); |
Collaborator
There was a problem hiding this comment.
these 2 methods are have different meanings:
refreshFromAzure requires reload the data from Azure(when user click the fresh button/menu item).
refreshItems implicits we can load from cache(when user click to expand a parent node.)
Contributor
Author
There was a problem hiding this comment.
refreshFromAzure are not used in current impl, remove it and will add it if we need it.
andxu
force-pushed
the
feature-explorer-signin
branch
from
1fa7825 to
7ffe950
Compare
wangmingliang-ms
previously approved these changes
Jul 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.