This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[#6590] Error while saving bot state to azure blob storage#6595
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 342214
💛 - Coveralls |
Contributor
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll |
tracyboehrer
approved these changes
Mar 7, 2023
johnataylor
approved these changes
Mar 7, 2023
This was referenced May 14, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6590
Description
This PR refactors the use of
AllowedTypesSerializationBinderto be optionally provided through aJsonSerializerconfiguration across Blobs and CosmosDB storage constructors.Behavior of
AllowedTypesSerializationBinder:JsonSerializer.SerializationBinder, otherwise it will not execute any related code to the class.Specific Changes
AllowedTypesSerializationBinderclass, leaving only the verification process when the class is provided.AllowedTypesSerializationBinderinternal class behavior, removing the process that loads the types dynamically to use only the ones provided by the user, and added a step to recognize types that are represented as a generic type (e.g. List).AllowedTypesSerializationBinderis provided through theJsonSerializerinstance.Testing
The following images show the unit tests passing successfully and how the new binder implementation works.

