Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Upgrade ANTLR to version 4.11.1 in Microsoft.Bot.Builder.Parsers.LU project#6670

Merged
tracyboehrer merged 2 commits into
mainfrom
southworks/update/luparser-antlr-version
Jul 12, 2023
Merged

Upgrade ANTLR to version 4.11.1 in Microsoft.Bot.Builder.Parsers.LU project#6670
tracyboehrer merged 2 commits into
mainfrom
southworks/update/luparser-antlr-version

Conversation

@ceciliaavila
Copy link
Copy Markdown
Collaborator

#minor

Description

This PR upgrades the ANTLR from 4.8.0 to 4.11.1 in Microsoft.Bot.Builder.Parsers.LU project.

Specific Changes

  • Upgraded ANTLR dependency version from 4.8.0 to 4.11.1 in Microsoft.Bot.Builder.Parsers.LU.csproj.
  • Updated the lexer and parser generated files in the Generated folder.
  • Updated the LUFileParser.g4 file to avoid new error type EOF_CLOSURE.

Testing

This image shows the unit tests passing after the changes.
image

@ceciliaavila ceciliaavila added the Automation: No parity PR does not need to be applied to other languages. label Jul 12, 2023
@ceciliaavila ceciliaavila requested a review from a team as a code owner July 12, 2023 16:54
@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 359729

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.003%) to 78.976%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/Microsoft.Bot.Connector.Streaming/Application/TimerAwaitable.cs 1 68.25%
Totals Coverage Status
Change from base Build 359562: -0.003%
Covered Lines: 25935
Relevant Lines: 32839

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 748aef5 into main Jul 12, 2023
@tracyboehrer tracyboehrer deleted the southworks/update/luparser-antlr-version branch July 12, 2023 20:03
tracyboehrer pushed a commit that referenced this pull request Jul 13, 2023
tracyboehrer added a commit that referenced this pull request Jul 13, 2023
* Upgrade Antlr4.Runtime to v.4.11.1 (#6670)

* Add WithAuthority to MSAL application level (#6671)

* Use LRUCache in ExpressionParser for efficient memory usage (#6667)

* Microsoft.Rest.ClientRuntime bump (#6662)

Co-authored-by: Tracy Boehrer <trboehre@microsoft.com>

* Updated NuGet.Packaging (#6652)

Co-authored-by: PVAShiproom <pvashiproom@microsoft.com>

---------

Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>
Co-authored-by: Joel Mut <62260472+sw-joelmut@users.noreply.github.com>
Co-authored-by: Ram Fattah <38049078+ramfattah@users.noreply.github.com>
Co-authored-by: Tracy Boehrer <trboehre@microsoft.com>
Co-authored-by: PVAShiproom <pvashiproom@microsoft.com>
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants