Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[Teams] Add support for meeting participants added/removed events#6677

Merged
tracyboehrer merged 5 commits into
mainfrom
southworks/add/teams-meeting-participant-events
Aug 16, 2023
Merged

[Teams] Add support for meeting participants added/removed events#6677
tracyboehrer merged 5 commits into
mainfrom
southworks/add/teams-meeting-participant-events

Conversation

@ceciliaavila
Copy link
Copy Markdown
Collaborator

@ceciliaavila ceciliaavila commented Jul 31, 2023

#minor

Description

This PR is based on #5809. It adds support to TeamsActivityHandler for meeting participant join/leave events.

Specific Changes

  • Added support for 2 new activity types - application/vnd.microsoft.meetingParticipantJoin and application/vnd.microsoft.meetingParticipantLeave.
  • Added functions to register handlers for when teams meeting participants are joined/left.
  • Added unit tests.

Testing

These images show the new unit tests passing and the implementation tested with a sample.
image
image
image

@ceciliaavila ceciliaavila added the Automation: Parity with js The PR needs to be ported to JS label Jul 31, 2023
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jul 31, 2023

Pull Request Test Coverage Report for Build 364374

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.006%) to 78.977%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableDate.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableDate.cs 1 93.94%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/Microsoft.Bot.Connector.Streaming/Transport/TransportHandler.cs 2 96.39%
/libraries/Microsoft.Bot.Builder/Teams/TeamsActivityHandler.cs 6 79.35%
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs 6 89.62%
/libraries/Microsoft.Bot.Builder.Dialogs.Declarative/Converters/InterfaceConverter.cs 10 81.16%
Totals Coverage Status
Change from base Build 362013: -0.006%
Covered Lines: 25959
Relevant Lines: 32869

💛 - Coveralls

@ceciliaavila
Copy link
Copy Markdown
Collaborator Author

Hi @tracyboehrer, there's a problem with the CI pipeline in this PR. We think is related to the custom Nuget feed.
Please, let us know if we can help solve this.
Thanks.

@ceciliaavila ceciliaavila marked this pull request as ready for review August 14, 2023 20:22
@ceciliaavila ceciliaavila requested a review from a team as a code owner August 14, 2023 20:22
@BruceHaley
Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

@tracyboehrer tracyboehrer merged commit 57e159a into main Aug 16, 2023
@tracyboehrer tracyboehrer deleted the southworks/add/teams-meeting-participant-events branch August 16, 2023 19:17
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: Parity with js The PR needs to be ported to JS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants