Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Remove unused deprecated adal package#6689

Closed
mit2nil wants to merge 1 commit into
microsoft:mainfrom
mit2nil:main
Closed

Remove unused deprecated adal package#6689
mit2nil wants to merge 1 commit into
microsoft:mainfrom
mit2nil:main

Conversation

@mit2nil
Copy link
Copy Markdown
Member

@mit2nil mit2nil commented Sep 7, 2023

#minor

@mit2nil mit2nil requested a review from a team as a code owner September 7, 2023 00:42
@mit2nil mit2nil changed the title Removed unused deprecated adal package Remov unused deprecated adal package Sep 7, 2023
@mit2nil mit2nil changed the title Remov unused deprecated adal package Remove unused deprecated adal package Sep 7, 2023
@tracyboehrer
Copy link
Copy Markdown
Member

We're going to hold on this. There are other alerts coming from the affected test project. This shouldn't not effect anyone consuming BF SDK packages as it's not published as a dependency. It exists only to run unit tests for the Connector package. There is another effort underway to correct this project though.

@ceciliaavila
Copy link
Copy Markdown
Collaborator

ceciliaavila commented Sep 7, 2023

Hi @tracyboehrer, this PR should solve the compliance blocker in Microsoft.Bot.Connector.Tests. We reviewed the rest of the project and there are no more references to ADAL.
Thanks.
Edit: This solves partially the compliance blocker. We are working on the remaining ADAL reference.

@ceciliaavila ceciliaavila added the Automation: No parity PR does not need to be applied to other languages. label Sep 7, 2023
@tracyboehrer
Copy link
Copy Markdown
Member

@ceciliaavila There is also an alert related to Microsoft.Rest.ClientRuntime.Azure.TestFramework

@tracyboehrer
Copy link
Copy Markdown
Member

This was resolved in: #6690

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants