This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Fix error when building activity with non-string text#6753
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 385156Details
💛 - Coveralls |
Contributor
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll |
tracyboehrer
approved these changes
Mar 5, 2024
tracyboehrer
pushed a commit
that referenced
this pull request
Apr 15, 2024
* Format to string the text and speak properties * Add unit test
This was referenced May 14, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#minor
Related BF-Composer Issue: microsoft/BotFramework-Composer#9692
Description
This PR adds a validation to avoid sending object values as the activity's text and speak.
With this change, we are matching JS implementation.
Specific Changes
Testing
These images show how the property was displayed before and after the fix.
