[AppBar] Fix AppBarItem OnClick not being handeled in popover#4421
Merged
[AppBar] Fix AppBarItem OnClick not being handeled in popover#4421
Conversation
vnbaaij
changed the title
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.2%
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #4418 where an AppItem's OnClick event handler was not being passed through to FluentAppBarItem components when rendered in the popover. The fix adds the OnClick parameter binding in two locations where FluentAppBarItem is instantiated.
Key Changes:
- Added
OnClick="@item.OnClick"parameter toFluentAppBarItemcomponents in both the main items list and the popover overflow items
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Core/Components/AppBar/FluentAppBar.razor | Added OnClick parameter binding to FluentAppBarItem components on lines 15 and 56 to properly pass through click event handlers |
| examples/Demo/Shared/Microsoft.FluentUI.AspNetCore.Components.xml | Auto-generated XML documentation updates for MessageService (appears unrelated to the AppBar fix) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dvoituron
approved these changes
Dec 24, 2025
|
The action is now executed, but the panel remains open... 
It should be click&close. |
Collaborator
Author
|
@LucaCris not sure if it should always be click and close but we can take a look on how to solve that. Please create a new issue for this as we can't do work on closed PRs and issues. |
vnbaaij
added a commit
that referenced
this pull request
Feb 13, 2026
- Make the popover close after handling onclick - use int for Count. In line with CounterBadge changes
Collaborator
Author
|
After some internal discussion, we agree. Should be click and close. Will create a PR for that. |
This was referenced Feb 13, 2026
This was referenced Feb 16, 2026
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4418. In popover, an AppItem's OnClick was not being passed through.