Shader Execution Reordering (SER) proposal by rasmusnv · Pull Request #277 · microsoft/hlsl-specs

rasmusnv · 2024-07-18T09:22:54Z

Add Shader Execution Reordering (SER) proposal for consideration.

damyanp

Looks ready to take into the repo for further review. Before completing the PR, please pick the next free proposal number (at time of writing this comment, that would be 0021) and rename the file and the reference to it on line 4 appropriately.

pow2clk

I'll disclose that I'm not a DXR expert. A lot of my feedback is copy editing, trying to make the document easier to read. I feel a bit stronger about my thoughts on testability and DXIL op feedback.

rasmusnv · 2024-09-26T08:00:59Z

@microsoft-github-policy-service agree company="NVIDIA"

damyanp

It looks like there's a large number of unresolved conversations on this PR - these either need to be moved into issues or addressed in the spec before we can merge it.

Co-authored-by: Greg Roth <grroth@microsoft.com>

Reduction of the complete SER implementation to just the HitObject type and its default constructor. Specification PR: microsoft/hlsl-specs#277

Flakebi · 2025-01-29T18:11:34Z

There are two comment threads above (one and two) about clarifications in the wording.
The threads were marked as resolved, but it would still be nice if the formulations can be clarified before this is merged.

rasmusnv · 2025-01-31T14:47:12Z

There are two comment threads above (one and two) about clarifications in the wording. The threads were marked as resolved, but it would still be nice if the formulations can be clarified before this is merged.

Please see the latest commit for clarifications.

Flakebi · 2025-01-31T14:49:37Z

Thanks for update, looks good to me now :)

rasmusnv · 2025-01-31T15:06:35Z

I think the PR is ready for merge. I resolved the remaining conversations as it looked like no changes were required at this point. For further changes we can open focused issues. I also picked up the next available number, 27. (Please ignore the close and re-open, that was a mistake).

damyanp · 2025-01-31T18:05:05Z

Thank you everyone! I'm going to go ahead an merge this PR. Options for further discussion:

open an issue in this repo against this proposal
submit a PR with a proposed change to the proposal
reach out directly to us if the above options are not possible

damyanp · 2025-01-31T18:34:43Z

If reordering is optional, I would suggest renaming the call to MaybeReorderThread so that it's clear to the caller that implementations are free to do this, or not.

#378

Co-authored-by: Greg Roth <grroth@microsoft.com> Co-authored-by: Tex Riddell <texr@microsoft.com> Co-authored-by: Radek Drabinski <radoslaw.drabinski@intel.com>

Reduction of the complete SER implementation to just the HitObject type and its default constructor. Specification PR: microsoft/hlsl-specs#277

Reduction of the complete SER implementation to just the HitObject type and its default constructor. This has most of the infrastructure changes in DXC to support SER, eg static member functions for builtins, HitObject scalar type. Specification PR: microsoft/hlsl-specs#277

Add Shader Execution Reordering (SER) proposal

6b05dbd

damyanp approved these changes Aug 14, 2024

View reviewed changes

Flakebi reviewed Aug 21, 2024

View reviewed changes

Comment thread proposals/NNNN-shader-execution-reordering.md

Comment thread proposals/NNNN-shader-execution-reordering.md Outdated

Comment thread proposals/NNNN-shader-execution-reordering.md Outdated

Comment thread proposals/NNNN-shader-execution-reordering.md Outdated

rdrabins reviewed Aug 29, 2024

View reviewed changes

Comment thread proposals/NNNN-shader-execution-reordering.md Outdated

rdrabins reviewed Aug 29, 2024

View reviewed changes

Comment thread proposals/NNNN-shader-execution-reordering.md

rdrabins reviewed Aug 29, 2024

View reviewed changes

Comment thread proposals/NNNN-shader-execution-reordering.md

pow2clk reviewed Sep 10, 2024

View reviewed changes

Flakebi reviewed Sep 13, 2024

View reviewed changes

Comment thread proposals/NNNN-shader-execution-reordering.md

Fix line breaks in tables and remove trailing spaces.

50bd7e0

damyanp requested changes Sep 26, 2024

View reviewed changes

Apply first batch of suggestions from pow2clk.

4d8349f

Co-authored-by: Greg Roth <grroth@microsoft.com>

llvm-beanz added the needs-triage label Oct 11, 2024

Be more clear about allowed replacement of terminated threads.

cf1318e

damyanp removed the needs-triage label Oct 16, 2024

damyanp added this to the Shader Model 6.9 milestone Oct 16, 2024

rasmusnv and others added 14 commits October 18, 2024 09:55

Add section about reorder behavior communicated from app.

a589481

Clarify text in introduction.

ff837e5

Clarify text in motivation.

1b915ca

Clarify text in Proposed Solution.

ee455fe

Mention NOP-HitObject earlier.

496c699

Reference HitKind.

76a74dc

Apply suggestions from code review

1b353ea

Co-authored-by: Greg Roth <grroth@microsoft.com>

Add back remark about maximum attribute size.

8a2e45c

Improve MakeNop.

7a63102

Clarify PAQ behavior.

d8f95b4

Replace DXC with DXIL-generating compiler

1f4f412

Merge FromRayQuery overloads

414fb44

Move HitObject_SetShaderTableIndex

05ca446

Move Generic State Value getters last

d60a3b8

simoll mentioned this pull request Jan 28, 2025

Shader Execution Reordering implementation microsoft/DirectXShaderCompiler#7094

Closed

simoll mentioned this pull request Jan 29, 2025

[SER] Patch 1: HitObject type lowering and SM 6.9 enablement microsoft/DirectXShaderCompiler#7097

Merged

Update coherency hint wording with llvm-beanz suggestion

35801a1

tex3d approved these changes Jan 29, 2025

View reviewed changes

Clarify memory coherence and visibility.

9e0514c

rasmusnv closed this Jan 31, 2025

rasmusnv reopened this Jan 31, 2025

Pick proposal number 27.

6418400

damyanp merged commit 7b59075 into microsoft:main Jan 31, 2025

damyanp mentioned this pull request Jan 31, 2025

[0027] Shader Execution Reordering: rename "ReorderThread" to "MaybeReorderThread" #378

Merged

MarijnS95 mentioned this pull request Mar 5, 2026

[Feature Request] [SPIRV] Support SPV_EXT_shader_invocation_reorder microsoft/DirectXShaderCompiler#8226

Open

Conversation

rasmusnv commented Jul 18, 2024

Uh oh!

damyanp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pow2clk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rasmusnv commented Sep 26, 2024

Uh oh!

damyanp left a comment

Choose a reason for hiding this comment

Uh oh!

Flakebi commented Jan 29, 2025

Uh oh!

rasmusnv commented Jan 31, 2025

Uh oh!

Flakebi commented Jan 31, 2025

Uh oh!

rasmusnv commented Jan 31, 2025

Uh oh!

damyanp commented Jan 31, 2025

Uh oh!

damyanp commented Jan 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants