Add proposal to adopt C++11 as the base language#314
Merged
Conversation
This proposal is for HLSL 202y to adopt C++ 11 as its base C++ language version and encorporate as many of C++ 11's features as reasonably fit within HLSL's language design.
bharadwajy
reviewed
Sep 13, 2024
bharadwajy
approved these changes
Sep 16, 2024
damyanp
approved these changes
Sep 16, 2024
Member
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
Sounds great to me!
Some nits in the comments around consistency between C++ 2021 vs C++11 vs C++ 11. I started calling them out but realized that there's quite a few (including some C++20s and you might not necessarily agree with me on which way you want to standardize, if at all.
damyanp
changed the title
Collaborator
Author
Consistency is good. I think the normalized spelling for C++ versions is "C++NN" (no space). Are you okay with me doing a pass to normalize that way? |
Member
Absolutely - I have no real preference other than that we're consistent! |
This addresses feedback from @damyanp
Collaborator
Author
|
Assigned this proposal number 23 |
llvm-beanz
added a commit
to llvm-beanz/hlsl-specs
that referenced
this pull request
Feb 9, 2025
This proposal is for HLSL 202y to adopt C++ 11 as its base C++ language version and encorporate as many of C++ 11's features as reasonably fit within HLSL's language design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposal is for HLSL 202y to adopt C++ 11 as its base C++ language version and encorporate as many of C++ 11's features as reasonably fit within HLSL's language design.