Skip to content

[WorkGraphs] Proposal to Add MaxRecordsPerNode attribute to NodeOutputArrays.#323

Merged
damyanp merged 8 commits into
microsoft:mainfrom
anupamachandra:main
Oct 31, 2024
Merged

[WorkGraphs] Proposal to Add MaxRecordsPerNode attribute to NodeOutputArrays.#323
damyanp merged 8 commits into
microsoft:mainfrom
anupamachandra:main

Conversation

@anupamachandra
Copy link
Copy Markdown
Contributor

WRT Workgraphs Feature:
This is the HLSL cpunterpart of the proposal to new node output attribute called MaxRecordsPerNode. This parameter is only required for output node arrays. This attribute specifies the maximum number of records that can be written to any single output node within a node array.
When determining backing store memory requirements, an implementation must assume the worst-case of MaxRecords written
to any single node in the output array. However, a common use-case is for a small number records to be written to
select nodes in a very large array of nodes. Some implementations can take advantage of this knowledge to significantly
reduce the backing store memory requirements while maintaining peak performance.

@anupamachandra anupamachandra changed the title First Draft [WorkGraphs] Proposal to Add MaxRecordsPerNode attribute to NodeOutputArrays. Sep 20, 2024
@anupamachandra
Copy link
Copy Markdown
Contributor Author

anupamachandra commented Sep 23, 2024 via email

Comment thread proposals/NNNN-max-records-per-node.md Outdated
Comment thread proposals/NNNN-max-records-per-node.md Outdated
Comment thread proposals/NNNN-max-records-per-node.md Outdated
@damyanp damyanp added this to the Shader Model 6.9 milestone Oct 16, 2024
@damyanp damyanp requested a review from tex3d October 30, 2024 18:34
Copy link
Copy Markdown
Collaborator

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to merge once we find a sponsor and update the document number NNNN.

Comment thread proposals/NNNN-max-records-per-node.md Outdated
Comment thread proposals/0025-max-records-per-node.md Outdated
@anupamachandra
Copy link
Copy Markdown
Contributor Author

@damyanp Is anything else required from my end?

@damyanp damyanp merged commit 3107ab5 into microsoft:main Oct 31, 2024
llvm-beanz pushed a commit to llvm-beanz/hlsl-specs that referenced this pull request Feb 9, 2025
…rrays. (microsoft#323)

WRT Workgraphs Feature:

This is the HLSL counterpart of the proposal to new node output attribute called MaxRecordsPerNode. This parameter is only required for output node arrays. This attribute specifies the maximum number of records that can be written to any single output node within a node array.

When determining backing store memory requirements, an implementation must assume the worst-case of MaxRecords written to any single node in the output array. However, a common use-case is for a small number records to be written to
select nodes in a very large array of nodes. Some implementations can take advantage of this knowledge to significantly
reduce the backing store memory requirements while maintaining peak performance.

---------

Co-authored-by: Anupama Chandrasekhar <anupamac@nvidia.com>
Co-authored-by: Tex Riddell <texr@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triaged

Development

Successfully merging this pull request may close these issues.

5 participants