Start working on HLSL initialization lists#329
Merged
Conversation
This one is a bit gnarly because it involves a lot of depth-first traversing of declarations, types, and initialization expresssions. Questions and suggestions on how to clarify are greatly appreciated!
llvm-beanz
force-pushed
the
cbieneman/decl.init.agg
branch
from
a51eec2 to
2da528e
Compare
pow2clk
reviewed
Oct 2, 2024
Contributor
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
I understand the depth-first traversal well enough. I think an example would be helpful to some, but perhaps that doesn't fit in this context?
Co-authored-by: Greg Roth <grroth@microsoft.com>
spall
reviewed
Oct 4, 2024
V-FEXrt
reviewed
Nov 19, 2024
bogner
approved these changes
Dec 6, 2024
V-FEXrt
approved these changes
Dec 9, 2024
spall
approved these changes
Dec 13, 2024
llvm-beanz
added a commit
to llvm-beanz/hlsl-specs
that referenced
this pull request
Feb 9, 2025
* Start working on HLSL initialization lists This one is a bit gnarly because it involves a lot of depth-first traversing of declarations, types, and initialization expressions. Questions and suggestions on how to clarify are greatly appreciated! Co-authored-by: Greg Roth <grroth@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is a bit gnarly because it involves a lot of depth-first traversing of declarations, types, and initialization expresssions.
Questions and suggestions on how to clarify are greatly appreciated!