Fix CMakeLists.txt to allow building when LLVM backend is configured …#200
Open
hrtan99 wants to merge 1 commit intomicrosoft:masterfrom
Open
Fix CMakeLists.txt to allow building when LLVM backend is configured …#200hrtan99 wants to merge 1 commit intomicrosoft:masterfrom
hrtan99 wants to merge 1 commit intomicrosoft:masterfrom
Conversation
…other than x86 and arm.
bharadwajy
suggested changes
Aug 29, 2024
Contributor
bharadwajy
left a comment
There was a problem hiding this comment.
There is no value in building llvm-mctoll for targets other than those it intends to support. Configuring as such in the publicly available repo would indicate that it is supported for targets other than x64 and ARM. Additionally, as is pointed out this change would include unnecessary components in the resulting binary and the needless complexity of adding ${LLVM_TARGETS_TO_BUILD} for no additional benefit.
The change in this PR can be made locally by anyone that wishes to build it on unsupported targets - and does so with an understanding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…other than x86 and arm.
Although llvm-mctoll currently only support x86 and arm, it should be built correctly when the backend of llvm project is configured of architectures other than x86 and arm.
Due to the following codes in mctoll, the linker will report undefined symbol for the MC layer components of other machine arch.
We can use
${LLVM_TARGETS_TO_BUILD}in CMakeLists file to avoid the error, though it includes unnecessary components of other architectures.