Skip to content

Allow semaphores and memory to be registered separately in ProxyService#264

Merged
aashaka merged 2 commits intomainfrom
aashaka/comm_helpers
Feb 8, 2024
Merged

Allow semaphores and memory to be registered separately in ProxyService#264
aashaka merged 2 commits intomainfrom
aashaka/comm_helpers

Conversation

@aashaka
Copy link
Contributor

@aashaka aashaka commented Feb 8, 2024

This is needed in use cases where SimpleProxyChannel does not suffice. For example, when a single semaphore is to be used for multiple tensors or when multiple semaphores should be associated with a tensor.

This is needed in use cases where SimpleProxyChannel does not suffice.
For example, when a single semaphore is to be used for multiple tensors
or when multiple semaphores should be associated with a tensor.
Copy link
Contributor

@chhwang chhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aashaka I guess the method names are not the right ones, because e.g., register_semaphore_with_proxy() doesn't take any semaphores as arguments. Can you please rename them?

@aashaka aashaka enabled auto-merge (squash) February 8, 2024 17:51
@aashaka aashaka merged commit d97fef4 into main Feb 8, 2024
@aashaka aashaka deleted the aashaka/comm_helpers branch February 8, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants