[NPKIT] Adding the NPKIT support for kernel allreduce7 in mscclpp-nccl#399
Merged
chhwang merged 3 commits intomicrosoft:mainfrom Jan 3, 2025
Merged
Conversation
yzygitzh
suggested changes
Dec 4, 2024
Contributor
yzygitzh
left a comment
yzygitzh
left a comment
There was a problem hiding this comment.
Overall looks good to me. We need add test for this change in the future.
yzygitzh
approved these changes
Dec 11, 2024
chhwang
reviewed
Dec 16, 2024
PedramAlizadeh
force-pushed
the
add_npkit_allreduce7
branch
from
6332176 to
cdb1a25
Compare
PedramAlizadeh
force-pushed
the
add_npkit_allreduce7
branch
from
cdb1a25 to
fa9108c
Compare
Contributor
Author
|
@microsoft-github-policy-service agree company="AMD" |
chhwang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.