Merge mscclpp-lang to mscclpp project#442
Merged
Binyang2014 merged 37 commits intomainfrom Jan 22, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 10 out of 25 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- python/mscclpp/language/init.py: Evaluated as low risk
- python/mscclpp/language/dag/init.py: Evaluated as low risk
- .azure-pipelines/nccl-api-test.yaml: Evaluated as low risk
- python/mscclpp/language/dag/lower.py: Evaluated as low risk
- python/mscclpp/language/types.py: Evaluated as low risk
- python/mscclpp/language/dag/instruction_dag.py: Evaluated as low risk
- python/mscclpp/language/utils.py: Evaluated as low risk
- python/examples/allreduce_allpairs_get.py: Evaluated as low risk
- python/examples/allreduce_allpairs_packet.py: Evaluated as low risk
- python/examples/allreduce_allpairs.py: Evaluated as low risk
- python/mscclpp/language/collectives.py: Evaluated as low risk
- python/mscclpp/language/rank.py: Evaluated as low risk
- python/mscclpp/language/buffer.py: Evaluated as low risk
- python/examples/allreduce_nvls.py: Evaluated as low risk
- .github/workflows/mscclpp-lang.yml: Evaluated as low risk
Comments suppressed due to low confidence (3)
python/examples/send_recv_packet.py:28
- The parameters
temp_bufferandtemp_buffer_indexare not used in thesend_recvfunction. This might be an oversight or an incomplete implementation.
c.put_packet(
python/examples/send_recv_packet.py:11
- [nitpick] The function name
send_recvis ambiguous as it is the same as in the other example. Consider renaming it tosend_recv_packetto avoid confusion.
def send_recv(instances):
python/examples/send_recv_packet.py:0
- Ensure that the new behavior introduced by
put_packetandcopy_packetis covered by tests.
def send_recv(instances):
…cclpp into binyli/mscclpp-lang
chhwang
requested changes
Jan 16, 2025
Contributor
mahdiehghazim
left a comment
mahdiehghazim
left a comment
There was a problem hiding this comment.
two general comments:
- did we validate that nccl-tests and rccl-tests are passing with this PR?
- in future, please add more descriptions for the commit messages
Contributor
Author
|
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mahdiehghazim
approved these changes
Jan 22, 2025
Contributor
mahdiehghazim
left a comment
mahdiehghazim
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step to merge msccl-tools into mscclpp repo. In this step will move all msccl related code, pass the current tests and do some necessary refactor.
Add
mscclpp.languagemoduleAdd
_InstructionOptimizerandDagOptimizerclass to optimize the dagAdd
DagLowerto lower dag to intermediate representationAdd documents for mscclpp.language
Remove msccl related code