Merged
Conversation
…en the index is excceed the size of the dst_ of SmChannelDeviceHandle
Binyang2014
reviewed
Feb 18, 2025
Binyang2014
approved these changes
Feb 18, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Binyang2014
approved these changes
Feb 19, 2025
chhwang
reviewed
Feb 19, 2025
| tempNcclDebugLevel = MSCCLPP_LOG_TRACE; | ||
| } | ||
|
|
||
| const char* disable_channel_cache = getenv("MSCCLPP_DISABLE_CHANNEL_CACHE"); |
Contributor
There was a problem hiding this comment.
Please use the env() function in env.cpp instead of calling getenv directly.
https://github.com/microsoft/mscclpp/blob/main/src/env.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add workaround of disabling channel cache.
Related runtime parameter: -x MSCCLPP_DISABLE_CHANNEL_CACHE=TRUE (Default value: False)
In this PR, some other features (e.g., ncclCommSplit) come from branch binyangli/nccl-api