Skip to content

Fix #458#568

Merged
chhwang merged 3 commits intomainfrom
binyli/fix
Jul 14, 2025
Merged

Fix #458#568
chhwang merged 3 commits intomainfrom
binyli/fix

Conversation

@Binyang2014
Copy link
Contributor

@Binyang2014 Binyang2014 commented Jul 13, 2025

Fix mscclpp_benchmark allreduce test

@Binyang2014 Binyang2014 requested review from chhwang and Copilot and removed request for Copilot July 13, 2025 18:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the allreduce test in the mscclpp_benchmark by updating parameter types, changing the reduction store to a broadcast, and adding compile-time branches for vector sizes.

  • Changed my_rank, num_ranks, and thread/index variables from size_t to int
  • Replaced switchChan.store with switchChan.broadcast in the reduction loop
  • Introduced if constexpr branches for different vector_size values and added runtime/assert guards for unsupported sizes
Comments suppressed due to low confidence (1)

python/mscclpp_benchmark/allreduce.cu:838

  • New branching logic for different vector_size values lacks corresponding tests. Please add tests for all supported vector_size paths (1, 2, 4, and 8) to ensure correct behavior.
    if (vector_size == 4) {

@Binyang2014
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@chhwang chhwang merged commit 604c345 into main Jul 14, 2025
23 of 29 checks passed
@chhwang chhwang deleted the binyli/fix branch July 14, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants