Conversation
Contributor
chhwang
commented
Jul 31, 2025
chhwang
commented
- Added more features in Dev Container
- Made it runnable on AMD platforms
Binyang2014
approved these changes
Jul 31, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the development container configuration to support both NVIDIA and AMD platforms, adding more development features and improving cross-platform compatibility.
- Added AMD platform support through new devcontainer configuration and ROCm-based setup
- Enhanced development environment with additional tools (SSH, debugging, documentation)
- Improved build scripts with better path handling and platform-specific installation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .devcontainer/devcontainer_amd.json | New AMD-specific dev container configuration with ROCm support |
| .devcontainer/devcontainer.json | Updated NVIDIA dev container with enhanced settings and new features |
| .devcontainer/Dockerfile | Enhanced with additional development tools and improved user management |
| tools/install.sh | New installation script supporting both NVIDIA and AMD platforms |
| tools/lint.sh | Fixed path handling to work correctly from different working directories |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Binyang2014
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.