Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges the ChannelTrigger union with the ProxyTrigger struct to simplify the trigger handling in the proxy service by eliminating the need for reinterpret_cast operations and consolidating the trigger structure definitions.
- Removed the separate
ChannelTriggerunion and moved its functionality intoProxyTrigger - Simplified proxy trigger handling by removing reinterpret_cast operations
- Updated device-side trigger construction to use the unified
ProxyTriggerstructure
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/port_channel.cc | Simplified handleTrigger to work directly with ProxyTrigger instead of casting |
| python/mscclpp/fifo_py.cpp | Removed Python bindings for ProxyTrigger field access |
| include/mscclpp/port_channel_device.hpp | Removed ChannelTrigger union and updated device calls to use ProxyTrigger directly |
| include/mscclpp/fifo_device.hpp | Enhanced ProxyTrigger to include the fields union and constructor from ChannelTrigger |
Binyang2014
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.