Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a hanging issue in the logging submodule by replacing pthread mutex with std::recursive_mutex to allow recursive lock acquisition in the same thread.
- Replaces pthread_mutex_t with std::recursive_mutex for thread-safe logging
- Uses RAII std::lock_guard for automatic lock management
- Removes manual mutex lock/unlock calls that could lead to hanging
Comments suppressed due to low confidence (1)
src/debug.cc:1
- Missing MIT license header. Please add the following license header at the top of the file:
// Copyright (c) Microsoft Corporation.\n// Licensed under the MIT License.
// Copyright (c) 2016-2022, NVIDIA CORPORATION. All rights reserved.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
chhwang
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #622, using std::recursive_mutex to allow acquiring
lockreclusively in the same thread