Make ncclReduce/ncclSend/ncclRecv work#643
Merged
Binyang2014 merged 5 commits intomainfrom Oct 3, 2025
Merged
Conversation
Binyang2014
requested review from
caiomcbr,
Copilot and
seagater
and removed request for
seagater
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements fallback functionality for ncclReduce, ncclSend, and ncclRecv operations by delegating to the underlying NCCL library when available. The changes enable these previously unimplemented functions to work by using dynamic library loading to call the corresponding NCCL functions.
Key changes:
- Added function pointers and dynamic symbol loading for ncclReduce, ncclSend, ncclRecv, ncclGroupStart, and ncclGroupEnd
- Implemented fallback logic in these functions to use NCCL when the shared library is loaded
- Fixed broadcast parameter validation logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallback to nccl for ncclReduce/ncclSend/ncclRecv