Skip to content

Handle writes to non-blocking pty instead of wrapping via Node's tty api #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyriar merged 10 commits into from
Dec 13, 2025
Merged

Handle writes to non-blocking pty instead of wrapping via Node's tty api #831

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3bc1409
Speculative fix for stream backpressure
Tyriar Dec 12, 2025
bb8a1af
Add additional change needed to fix it
Tyriar Dec 12, 2025
b8ecd5e
Use raw write stream, handle partial writes/kernel backpressure
Tyriar Dec 13, 2025
8b2b77b
Remove unneeded write stream
Tyriar Dec 13, 2025
3538d16
Remove unwanted logs
Tyriar Dec 13, 2025
80b2af7
Tidy up comments
Tyriar Dec 13, 2025
872ff8e
Add setting of encoding on the read socket back
Tyriar Dec 13, 2025
1674fdf
Move props to top
Tyriar Dec 13, 2025
6bb38cc
Use os.constants.errno
Tyriar Dec 13, 2025
c6b06ed
Revert "Use os.constants.errno"
Tyriar Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/unixTerminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const DESTROY_SOCKET_TIMEOUT_MS = 200;
export class UnixTerminal extends Terminal {
protected _fd: number;
protected _pty: string;
private _writeSocket!: net.Socket; // HACK: This is unsafe

protected _file: string;
protected _name: string;
Expand Down Expand Up @@ -103,6 +104,8 @@ export class UnixTerminal extends Terminal {
const term = pty.fork(file, args, parsedEnv, cwd, this._cols, this._rows, uid, gid, (encoding === 'utf8'), helperPath, onexit);

this._socket = new tty.ReadStream(term.fd);
// HACK: This needs to be created or all some data may get lost
this._writeSocket = new tty.WriteStream(term.fd);
if (encoding !== null) {
this._socket.setEncoding(encoding);
}
Expand Down Expand Up @@ -171,7 +174,12 @@ export class UnixTerminal extends Terminal {
if (err) {
console.log('pty write error', err);
}
console.log('written', written);
});
// TODO: Understand why this hangs the process
// this._writeSocket.write(data, (err) => {
Comment thread
Tyriar marked this conversation as resolved.
Outdated
// console.log('err', err);
// });
}

/* Accessors */
Expand Down