Add sysroot to compile Linux prebuilds against glibc 2.28#853
Add sysroot to compile Linux prebuilds against glibc 2.28#853deepak1556 merged 4 commits intomicrosoft:mainfrom
Conversation
|
Approach LGTM, can you also add a step in the CI to verify the binaries contain the required version of glibc. Refs https://github.com/microsoft/vscode/blob/d2894816734dc9141885b802805801b67d70e6e9/build/azure-pipelines/linux/steps/product-build-linux-compile.yml#L238-L250 as an example. |
Thanks @deepak1556! Great suggestion! Added in 965cf18 which did catch an issue. Fixed in 26ba629 |
|
👋 Went to add CI for the cross-compiled builds and found the linux arm build was not using the sysroot correctly. PR to fix and add CI: |
Fixes #851