Repository navigation
[EP ABI] Add Graph_GetModelPath API function - #25424
Merged
Adrian Lizarraga (adrianlizarraga) merged 7 commits intoJul 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Graph_GetModelPath API function to the ORT Graph API that allows execution providers to retrieve the file path of the ONNX model. This is particularly useful for execution providers that need to load EPContext models (compiled models) and determine the path to EPContext node binaries.
Key changes:
- Added
Graph_GetModelPathfunction to the C API that returns the model's file path - Implemented the function across all graph type implementations with appropriate fallbacks
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| include/onnxruntime/core/session/onnxruntime_c_api.h | Adds public API declaration with documentation |
| onnxruntime/core/session/ort_apis.h | Adds internal API declaration |
| onnxruntime/core/session/onnxruntime_c_api.cc | Implements the API function and adds to API table |
| onnxruntime/core/graph/abi_graph_types.h | Adds pure virtual method to base OrtGraph class |
| onnxruntime/core/graph/ep_api_types.h | Adds method declaration to EpGraph class |
| onnxruntime/core/graph/ep_api_types.cc | Implements method using GraphViewer's ModelPath |
| onnxruntime/core/graph/model_editor_api_types.h | Implements method returning empty string fallback |
| onnxruntime/test/ep_graph/test_ep_graph.cc | Adds test verification of the new API function |
Adrian Lizarraga (adrianlizarraga)
marked this pull request as ready for review
July 16, 2025 18:35
Adrian Lizarraga (adrianlizarraga)
requested review from
Chi Lo (chilo-ms),
George Wu (jywu-mysoft) and
Scott McKay (skottmckay)
July 16, 2025 18:35
Adrian Lizarraga (adrianlizarraga)
requested a review
from Dmitri Smirnov (yuslepukhin)
July 17, 2025 08:45
George Wu (jywu-mysoft)
previously approved these changes
Jul 22, 2025
Contributor
|
Dmitri Smirnov (@yuslepukhin) can you review again? |
Dmitri Smirnov (yuslepukhin)
suggested changes
Jul 22, 2025
Edward Chen (edgchen1)
approved these changes
Jul 22, 2025
Contributor
Author
|
closing and reopening to make CI rerun |
Adrian Lizarraga (adrianlizarraga)
requested a review
from Dmitri Smirnov (yuslepukhin)
July 23, 2025 08:22
Contributor
Author
|
hi Dmitri Smirnov (@yuslepukhin), can you please review again? |
Dmitri Smirnov (yuslepukhin)
approved these changes
Jul 23, 2025
Adrian Lizarraga (adrianlizarraga)
deleted the
adrianl/EpABI_GetModelPath
branch
July 23, 2025 17:00
Contributor
|
Hi there! We haven't cut the release branch for this version yet, so I'm removing the |
Sanket Kale (sanketkaleoss)
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
### Description Adds `Graph_GetModelPath` API function. ### Motivation and Context An EP that loads an EPContext model (i.e., compiled model) needs to know the base path of the model to determine the path the EPContext node binary (if stored in a file).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
Graph_GetModelPathAPI function.Motivation and Context
An EP that loads an EPContext model (i.e., compiled model) needs to know the base path of the model to determine the path the EPContext node binary (if stored in a file).