Skip to content

Remove training packages from onnxruntime-ios-packaging-pipeline - #25451

Merged
vraspar merged 9 commits into
mainfrom
vraspar/remove-ios-training-packaging
Aug 6, 2025
Merged

vraspar merged 9 commits into
mainfrom
vraspar/remove-ios-training-packaging

Conversation

@vraspar

@vraspar vraspar commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

Description

remove support for multiple package variants (Full and Training) in the Apple packaging pipeline, consolidating the codebase to only support the Full variant. The changes simplify the code by eliminating the PackageVariant enum, related logic, and configuration files for the Training variant.

@vraspar
vraspar marked this pull request as ready for review July 18, 2025 18:42
@snnn

Copy link
Copy Markdown
Contributor

It's failing:

test_apple_packages.py: error: unrecognized arguments: --variant Full

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

…-packaging-build-stage.yml

Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
@snnn

Copy link
Copy Markdown
Contributor

Hope we can get it included in this upcoming release.

@vraspar
vraspar merged commit eff5b9a into main Aug 6, 2025
@vraspar
vraspar deleted the vraspar/remove-ios-training-packaging branch August 6, 2025 20:16
Sanket Kale (sanketkaleoss) pushed a commit to sanketkaleoss/onnxruntime that referenced this pull request Aug 11, 2025
…rosoft#25451)

### Description
remove support for multiple package variants (`Full` and `Training`) in
the Apple packaging pipeline, consolidating the codebase to only support
the `Full` variant. The changes simplify the code by eliminating the
`PackageVariant` enum, related logic, and configuration files for the
`Training` variant.

---------

Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
Maximilian Müller (gedoensmax) pushed a commit to gedoensmax/onnxruntime that referenced this pull request Sep 2, 2025
…rosoft#25451)

### Description
remove support for multiple package variants (`Full` and `Training`) in
the Apple packaging pipeline, consolidating the codebase to only support
the `Full` variant. The changes simplify the code by eliminating the
`PackageVariant` enum, related logic, and configuration files for the
`Training` variant.

---------

Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants