Skip to content

[webgpu] Add more GEMM test - #25556

Merged
Xiaofei Han (xiaofeihan1) merged 9 commits into
microsoft:mainfrom
xiaofeihan1:xiaofeihan/add_more_gemm_test
Aug 14, 2025
Merged

[webgpu] Add more GEMM test#25556
Xiaofei Han (xiaofeihan1) merged 9 commits into
microsoft:mainfrom
xiaofeihan1:xiaofeihan/add_more_gemm_test

Conversation

@xiaofeihan1

@xiaofeihan1 Xiaofei Han (xiaofeihan1) commented Jul 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add alpha/beta and int/f16 GEMM test and fix some error for GEMM shader.

@xiaofeihan1
Xiaofei Han (xiaofeihan1) force-pushed the xiaofeihan/add_more_gemm_test branch from 18913a9 to cbacbb7 Compare July 28, 2025 09:02
@guschmue Guenther Schmuelling (guschmue) added the ep:WebGPU ort-web webgpu provider label Jul 28, 2025
@xiaofeihan1 Xiaofei Han (xiaofeihan1) changed the title Add more GEMM test [WebGPU] Add more GEMM test Jul 29, 2025
@xiaofeihan1 Xiaofei Han (xiaofeihan1) changed the title [WebGPU] Add more GEMM test [webgpu] Add more GEMM test Jul 29, 2025
@xiaofeihan1
Xiaofei Han (xiaofeihan1) force-pushed the xiaofeihan/add_more_gemm_test branch from dbdc9dd to 1f653f3 Compare July 29, 2025 01:46
@xiaofeihan1
Xiaofei Han (xiaofeihan1) force-pushed the xiaofeihan/add_more_gemm_test branch from 1f653f3 to be120f7 Compare July 30, 2025 04:50
qjia7
Jiajia Qin (qjia7) reviewed Jul 31, 2025
View reviewed changes
Comment thread onnxruntime/test/providers/cpu/math/gemm_test.cc Resolved
Comment thread onnxruntime/test/providers/cpu/math/gemm_test.cc Resolved
Comment thread onnxruntime/test/providers/cpu/math/gemm_test.cc Resolved
qjia7
Jiajia Qin (qjia7) previously approved these changes Aug 11, 2025
View reviewed changes

@qjia7 Jiajia Qin (qjia7) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@xiaofeihan1

Xiaofei Han (xiaofeihan1) commented Aug 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hello, Yulong Wang (@fs-eire) Guenther Schmuelling (@guschmue) PTAL, thanks!!!

@fs-eire

Yulong Wang (fs-eire) commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

Average CI run time increased 15 min from ~1h45min to ~2h0min. Rerun to double check

@xiaofeihan1

Xiaofei Han (xiaofeihan1) commented Aug 12, 2025

Copy link
Copy Markdown
Contributor Author

Average CI run time increased 15 min from ~1h45min to ~2h0min. Rerun to double check

This might be caused by the code. I added coverage for alpha_beta_values as a inner loop, which makes the GEMM test take several times longer than before:(

@xiaofeihan1

Xiaofei Han (xiaofeihan1) commented Aug 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Average CI run time increased 15 min from ~1h45min to ~2h0min. Rerun to double check

This might be caused by the code. I added coverage for alpha_beta_values as a inner loop, which makes the GEMM test take several times longer than before:(

Updated the PR. Use seprate test case to cover alpha/beta scenario for small/big matrix, which can reduce the time of pipeline.

@fs-eire

Yulong Wang (fs-eire) commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

close & reopen to trigger the check

@xiaofeihan1
Xiaofei Han (xiaofeihan1) merged commit 3a94a67 into microsoft:main Aug 14, 2025
Maximilian Müller (gedoensmax) pushed a commit to gedoensmax/onnxruntime that referenced this pull request Sep 2, 2025
@xiaofeihan1 @gedoensmax
[webgpu] Add more GEMM test (microsoft#25556)
6d8b7c4 
Add alpha/beta and int/f16 GEMM test and fix some error for GEMM shader.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qjia7 Jiajia Qin (qjia7) qjia7 left review comments
@guschmue Guenther Schmuelling (guschmue) Awaiting requested review from guschmue
+1 more reviewer
@fs-eire Yulong Wang (fs-eire) fs-eire approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ep:WebGPU ort-web webgpu provider

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiaofeihan1 @fs-eire @qjia7 @guschmue