Repository navigation
Revert "Fix/gate cuda ci registry auth" - #33894
Merged
Tianlei Wu (tianleiwu) merged 1 commit intoNov 4, 2026
Merged
Conversation
This reverts commit 3605f37.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Fork-controlled code can execute on build and GPU runners with privileged Azure managed identities, creating a critical security exposure that a read-only GITHUB_TOKEN does not mitigate.
1 open issue
What changed in this PR
Reverts #33376’s fork-PR restrictions in ONNX Runtime’s Linux CI workflows, restoring the previous job eligibility and permission placement.
Changes:
- Removes fork-origin guards from the reusable Linux build job and CUDA build/test jobs.
- Moves CUDA build write permissions from job scope back to workflow scope.
| File | Description |
|---|---|
.github/workflows/reusable_linux_build.yml |
Removes the shared build job’s fork-origin restriction. |
.github/workflows/linux_cuda_ci.yml |
Removes CUDA job fork restrictions and restores workflow-level write permissions. |
Review effort: Balanced
| jobs: | ||
| build_test_pipeline: | ||
| if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository | ||
| runs-on: ["${{ inputs.pool_name }}"] |
Akshay Sonawane (apsonawane)
approved these changes
Nov 4, 2026
Tianlei Wu (tianleiwu)
deleted the
revert-33376-fix/gate-cuda-ci-registry-auth
branch
November 4, 2026 22:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #33376