Fix GetRegisteredOrEnabledProviders() documentation claiming list is small#2348
Merged
Fix GetRegisteredOrEnabledProviders() documentation claiming list is small#2348
Conversation
…ehavior Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix count discrepancy in GetRegisteredOrEnabledProviders method
Fix GetRegisteredOrEnabledProviders() documentation claiming list is small
Jan 12, 2026
brianrob
reviewed
Jan 12, 2026
src/TraceEvent/TraceEventSession.cs
Outdated
| /// <para> | ||
| /// This is a relatively small list (less than 1000), unlike GetPublishedProviders. | ||
| /// This list can be quite large (often 2000+ entries), potentially larger than GetPublishedProviders. | ||
| /// Note that not all providers returned will have names available via GetProviderName(). |
Member
There was a problem hiding this comment.
Suggested change
| /// Note that not all providers returned will have names available via GetProviderName(). |
Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
Contributor
Author
marklio
approved these changes
Jan 13, 2026
Collaborator
marklio
left a comment
There was a problem hiding this comment.
LGTM. Should there be an enumeration API that allows enumeration without a "big" heap allocation?
Member
Yeah, likely. This is one of those things where I think I'd like to go through the API surface and see what new APIs we might add. The API surface was designed before many of the modern techniques and so you'll find these littered all throughout. |
This was referenced Jan 29, 2026
Merged
This was referenced Feb 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for
GetRegisteredOrEnabledProviders()incorrectly stated it returns "a relatively small list (less than 1000), unlike GetPublishedProviders." In practice, this method returns ~2500+ providers, significantly more thanGetPublishedProviders()which returns ~1100.Changes
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.