Support resolving Python environments #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Jun 17, 2024
DonJayamanne
commented
Jun 17, 2024
| "env.bak", | ||
| "venv.bak", | ||
| "Scripts", // If the folder ends bin/scripts, then ignore it, as the parent is most likely an env. | ||
| "bin", // If the folder ends bin/scripts, then ignore it, as the parent is most likely an env. |
Collaborator
Author
There was a problem hiding this comment.
Ignore searching some known directories
DonJayamanne
commented
Jun 17, 2024
| ) -> Option<ResolvedEnvironment> { | ||
| // First check if this is a known environment | ||
| let env = PythonEnv::new(executable.to_owned(), None, None); | ||
| if let Some(env) = identify_python_environment_using_locators(&env, locators) { |
DonJayamanne
commented
Jun 17, 2024
|
|
||
| let mut handlers = HandlersKeyedByMethodName::new(Arc::new(context)); | ||
| handlers.add_request_handler("refresh", handle_refresh); | ||
| handlers.add_request_handler("resolve", handle_resolve); |
Collaborator
Author
There was a problem hiding this comment.
Add resolve request
DonJayamanne
commented
Jun 17, 2024
| // if the prefix is not defined, try to get this. | ||
| // For instance, if the file is bin/python or Scripts/python | ||
| // And we have a pyvenv.cfg file in the parent directory, then we can get the prefix. | ||
| if prefix.is_none() { |
Collaborator
Author
There was a problem hiding this comment.
Bug fix caught via CI
DonJayamanne
commented
Jun 17, 2024
| .unwrap_or_default(); | ||
| } | ||
| if let Some(project) = &self.project { | ||
| writeln!(f, " Project : {}", project.to_str().unwrap()).unwrap_or_default(); |
Collaborator
Author
There was a problem hiding this comment.
Minor refactor
Co-authored-by: Karthik Nadig <[email protected]>
Co-authored-by: Karthik Nadig <[email protected]>
Co-authored-by: Karthik Nadig <[email protected]>
Co-authored-by: Karthik Nadig <[email protected]>
Co-authored-by: Karthik Nadig <[email protected]>
Co-authored-by: Karthik Nadig <[email protected]>
rebornix
approved these changes
Jun 17, 2024
karthiknadig
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.