Repository navigation
Use the resolved dotnet executable for SDK discovery - #761
Merged
Andy Gerlicher (AndyGerlicher) merged 1 commit intoNov 16, 2026
Merged
Andy Gerlicher (AndyGerlicher) merged 1 commit into
Andy Gerlicher (AndyGerlicher) merged 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Andy Gerlicher (AndyGerlicher)
approved these changes
Nov 16, 2026
Andy Gerlicher (AndyGerlicher)
merged commit Nov 16, 2026
0125dfc
into
microsoft:main
3 checks passed
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the full path of the already-resolved
dotnetexecutable when launching SDK discovery.Problem
The relevant issue summary is:
Although
TryResolveDotNetCoreSdkreceives the located executable as aFileInfo, the discovery process used the bare namedotnet. That allowed process lookup to select an executable fromPATHinstead, potentially interrogating a different installation.Fix
Set
ProcessStartInfo.FileNametodotnetFileInfo.FullName. Keep the--infoinvocation, working directory, output redirection, and other process settings unchanged.Regression test
Add
DotNetCoreSdkResolverTests.TryResolveDotNetCoreSdk_DoesNotFallBackToDotNetOnPath:false.The test runs in an environment where
dotnetis available onPATH, ensuring a missing resolved executable does not silently succeed by falling back to that installation.Validation
Built and tested this branch independently on Windows, targeting .NET 10:
Result: 1 passed, 0 failed, 0 skipped; build completed with 0 warnings and 0 errors.