Add SNMALLOC_EXPORT annotation to c++ allocator functions.#822
Merged
mjp41 merged 1 commit intomicrosoft:mainfrom Mar 3, 2026
Merged
Add SNMALLOC_EXPORT annotation to c++ allocator functions.#822mjp41 merged 1 commit intomicrosoft:mainfrom
mjp41 merged 1 commit intomicrosoft:mainfrom
Conversation
akrieger
force-pushed
the
export_new_delete
branch
from
f3b7feb to
4fa3019
Compare
Member
|
@akrieger could you clang-format. |
akrieger
force-pushed
the
export_new_delete
branch
from
4fa3019 to
7637b8c
Compare
Contributor
Author
|
formatted |
mjp41
approved these changes
Mar 3, 2026
Member
mjp41
left a comment
mjp41
left a comment
There was a problem hiding this comment.
LGTM, I think the CI failures look like packaging issues with Mac. Nothing related to this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CleverRaven/Cataclysm-DDA#85620 showed that when compiling snmalloc statically into a binary the new/delete overrides are stripped by
stripby default because they appear unused. Add the existing SNMALLOC_EXPORT annotation to these functions so snmalloc can be used in combination with-fvisibility=hiddenwhen overriding the c++ allocators, so that shared libraries use the overrides instead of loading the system default implementations.