Is TestNodeFileArtifact the way we report attachments in MTP?

[bradwilson]

I'm trying to do the Microsoft.Testing.Platform equivalent to VSTest's TestResult.Attachments to add attachments from xUnit.net v3.

This test:

using System.IO;
using Xunit;

namespace Empty;

public class UnitTest
{
    [Fact]
    public void Passing()
    {
        var bytes = File.ReadAllBytes("logo-128-transparent.png");

        TestContext.Current.AddAttachment("Note", "This is important information");
        TestContext.Current.AddAttachment("Logo", bytes, "image/png");
    }
}

Yields this output when run, which seems reasonable:

xUnit.net v3 Microsoft.Testing.Platform Runner v1.1.0-pre.11-dev+4fdcdbe543 (64-bit .NET 8.0.12)

  In process file artifacts produced:
    - For test 'Empty.UnitTest.Passing': C:\...\Note.txt
    - For test 'Empty.UnitTest.Passing': C:\...\Logo.png

Test run summary: Passed! - bin\Debug\net8.0\cs.dll (net8.0|x64)
  total: 1
  failed: 0
  succeeded: 1
  skipped: 0
  duration: 91ms

(Paths shortened for clarity)

Q1: Is this the correct replacement for attachments?

---

Running the test in Test Explorer in MTP mode, does not yield any attachments:

Compared to running the test in Test Explorer in VSTest mode:

Q2: Am I doing something wrong? Or does Test Explorer not yet support attachments like this?

[nohwnd]

I see attachments to be described in the protocol. but the only 2 mentions of the update messages are in the docs:

https://grep.app/search?q=AttachmentUpdatesParams

is this implemented for vs @drognanar ?

[bradwilson]

I don't see AttachmentUpdatesParams in the libraries, only in the protocol definition: https://github.com/search?q=repo%3Amicrosoft%2Ftestfx%20AttachmentUpdatesParams&type=code

[Evangelink]

I confirm this is also not working for MSTest.

[bradwilson]

People are starting to ask when this is going to work in Team Explorer now that it defaults to MTP mode. I am currently required to tell people that the only workaround is to disable MTP support in Test Explorer.

Any update on when we should expect support in MTP and Test Explorer? @nohwnd @Evangelink

[drognanar]

Currently all of the attachments/error/stdout messages are expected to be added as the TestNode properties.
So if VS receives the following payload, It should show the attachment in the Test Explorer.

{
  "uid": "Some.FQN.Test",
  "display-name": "Test",
  "execution-state": "failed",
  "attachments.0.uri": "C:\\File.mp4",
  "attachments.0.display-name": "File.mp4",
  "attachments.0.description": "Recording of the test failure",
}

Last time I synced with @Evangelink, the idea was to not use the TestNodeFileArtifact for the VS integration, but rather implement the converters to include the properties on the TestNode and serialize/deserialize them to the JSON format above.