Skip to content

Replace Extensions with MSTest.Uwp and MSTest.WinUI packages - #12435

Closed
Amaury Levé (Evangelink) wants to merge 3 commits into
mainfrom
dev/amauryleve/mstest-platform-packages
Closed

Amaury Levé (Evangelink) wants to merge 3 commits into
mainfrom
dev/amauryleve/mstest-platform-packages

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Pull request

Summary

Retire TestFramework.Extensions and make TestFramework.csproj the actual MSTest.TestFramework package owner. Add explicit MSTest.Uwp and MSTest.WinUI packages containing their existing UI attributes and matching adapter/platform-services payloads and satellites.

MSTest.Uwp supports both classic uap10.0.16299 and modern .NET 10/.NET 11 UWP. Modern UWP does not select WinUI. Ordinary MSTest.TestAdapter no longer ships or property-swaps UI payloads. SDK, helper/source-generation, CPM, multi-TFM, direct-reference, classic metapackage, samples and directly dependent Bazel consumers follow the explicit boundary.

Relates to #7225. This is the remaining package stage after merged #12412 and final #12428, based on e1c66e5cbfa844384a59343c3727821f97e2a09a. It retains the final prerequisite's Hosting alignment and append-only evidence intent.

Intentional next-major compatibility change: consumers of MSTest.TestFramework.Extensions.dll must migrate package/assembly references and recompile. UI consumers now use the same non-UI core as ordinary helper libraries. Modern UI therefore sees the shared directory/deployment APIs; all six UI-host directory getters return null even when their property-bag entries are populated, and unsupported [DeploymentItem] use fails before the body, including inheritance and both generator modes. Historical API files remain byte-identical inert .txt.history snapshots, not deleted or promoted by release tooling.

No launcher/protocol, application-owned Windows runtime/activation responsibility, apartment/exception machinery, or migration analyzer is added. No merge or Agent merge is requested.

Design and decision record

Maintained package decision and evidence, plus the directly dependent native-build decision.

Keeping renamed flavor bundles with separate core copies was the smaller layout-only alternative, but would retain core identity/helper-composition hazards and contradict the agreed single-core design. Conventional UI lib/<tfm> assets, per-TFM package-local adapter assets/satellites and an exact [matching version] core dependency replace the old paired core-swapping mechanism. Composition checks use the SDK-resolved current-inner-TFM package graph, including transitive references and excluded build assets; non-SDK projects retain imported-marker checks. Restore/source builds retain adapter variants; only the ordinary package's pack traversal/dependency groups are filtered.

Demonstration

This changes a shipping package boundary, not a rendered report/layout; exact identities, hashes, real activation and readable transcripts are stronger evidence than a staged screenshot.

Shared core / ordinary adapter / Uwp / WinUI source graph: pack exit 0
Ordinary adapter: 54 entries, no UI payload, net462/net10/net11 dependency groups only
Classic UWP: SDK + metapackage + direct MSTest.Uwp activate and run plain/UI tests
Modern UWP: net10 and net11 activate and run plain/UI tests; inherited deployment rejected
WinUI: packaged full-trust/AppContainer + unpackaged dispatch/startup/timeout paths pass
Native .NET SDK 10.0.401: activated host, failure/retry, discovery and fallback contracts pass
Counterfactual: 9 executed -> 7 intended failures / 2 ordinary passes
Restored behavior: same 9 executed -> 9 passed

Real activation preflight passed. Every registration and short-path mapping created by these runs was cleaned; a read-only leak check reports no remaining reserved-prefix registrations or task-owned mappings.

Validation and regression proof

Repository-pinned SDK 12.0.100-alpha.1.26556.115; Release MSTest 5.0.0-dev / MTP 3.0.0-dev. Outer acceptance hosts are net12.0; generated consumers exercise the named target frameworks. External producer dependencies reuse the verified immutable cache. Same-version product consumers use fresh effective caches; package/cache/compiler/runtime/satellite hashes and loaded app paths are checked or recorded.

Delivery head: 00428d48c212cf3630dcf6fa31d131c5ae745c98 (173 changed files). Shipping source/tests are unchanged from the validated 33faf4889ca048ccdcb508c2088b15dd5f1efd21 snapshot. The final commit changes only native Bazel package wiring and the two decision records. Its native/package inputs were stable through the final UI archive build/layout validation (retained patch SHA-256 6E3C2D1C7284BE2B387DDFFC5A5E26E07AC845023DF04372FD0D72986ACA362E). The four final shipping-package hashes are preserved in the linked decision record.

The producer command is reproducible without the broad Arcade glob:

$root = (Get-Location).Path
[xml]$solution = Get-Content TestFx.slnx -Raw
$members = @($solution.SelectNodes('//Project[@Path]') | ForEach-Object { [string]$_.Path } |
  Where-Object { $_.StartsWith('src/', [StringComparison]::Ordinal) } | Sort-Object -Unique)
$sourceFilter = Join-Path $env:TEMP ('mstest-source-' + [Guid]::NewGuid().ToString('N') + '.slnf')
@{ solution = @{ path = (Join-Path $root 'TestFx.slnx'); projects = $members } } |
  ConvertTo-Json -Depth 5 | Set-Content $sourceFilter -Encoding utf8
.\build.cmd -pack -c Release -projects $sourceFilter /m:8 /nr:false /bl:artifacts\log\Release\platform-packages.binlog
# Passed: 42 actual source members, exit 0, zero warnings/errors; package verifier passed.

For the following exact selectors, the executed command shape is:

$mstest = 'test\IntegrationTests\MSTest.Acceptance.IntegrationTests\MSTest.Acceptance.IntegrationTests.csproj'
$mtp = 'test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj'
$env:TESTFX_RUN_WINDOWS_APP_MODEL_TESTS = '1'
# Native row additionally sets TESTFX_DOTNET_10_PATH to the isolated 10.0.401 installation
# and DOTNET_CLI_CONTEXT_VERBOSE=1, preserving SDK tracing.
.\.dotnet\dotnet.exe test --project $project -c Release --no-build --filter $filter `
  -p:UsingDotNetTest=true "-p:ArtifactsTestResultsDir=$results" "-bl:$binlog" `
  --no-artifact-post-processing --show-test-results failed

Independent --list-tests json selections were reconciled with source and fresh TRX using the repository execution gate. All green rows have exit 0, zero skips.

Requirement Project / exact selector Result
Package/API/identity/satellites + UI pre-body guard $mstest: FullyQualifiedName~CoreFrameworkAssemblyTests|FullyQualifiedName~WindowsApplicationModelPackageTests|FullyQualifiedName~.WinUITests. 43/43 passed.
SDK/helpers/CPM/multi-TFM/net462 $mstest: FullyQualifiedName~SdkTests.MSTestSdk_|FullyQualifiedName~SdkTests.SettingIsTestApplication|FullyQualifiedName~SdkTests.TestApplicationRunsTestsFromReferencedMSTestSdkTestLibrary|FullyQualifiedName~SourceGenerationNonAotTests.MSTestSdk_SourceGenerationOptIn_DoesNotFlowTransitively|FullyQualifiedName~FrameworkTargetingTests.PackedPackages_UseMatchingFrameworkAssetsAndRuntime|FullyQualifiedName~NetFrameworkRunnerCompatibilityTests 65/65 passed.
Conflicting direct/transitive pairs, including excluded build assets $mstest: FullyQualifiedName~SdkTests.ExplicitPackages_RejectConflictingAdaptersBeforeCompilation 9/9 passed; both package IDs are asserted in the actual inner graph, including a real ProjectReference.
Real classic/modern UWP + unpackaged WinUI $mstest: FullyQualifiedName~ClassicUwpTests|FullyQualifiedName~ModernUwpTests|FullyQualifiedName~UnpackagedWinUITests 12/12 passed, including NET10/NET11 execution and x86/ARM64 builds.
Real packaged WinUI $mtp: FullyQualifiedName~PackagedWinUITests.PackagedFullTrustWinUI_RegistersActivatesConnectsBackRunsUiTestsAndCleansUp|FullyQualifiedName~PackagedWinUITests.PackagedAppContainerWinUI_RunsThroughMtpControllerAndPublishesTrx|FullyQualifiedName~PackagedWinUITests.PackagedAppContainerWinUI_ExplicitIntegrationPublishesTrx 3/3 passed.
Hosting/core lifetime and dependency $mtp: FullyQualifiedName~GeneratedMSTestHostingInjectionTests 8/8 passed, net462/net10/net11 and unsupported AppDomain paths.
.NET Framework assembly-qualified configuration $mstest: FullyQualifiedName~DataSourceTests.TestDataSourceFromAppConfig 1/1 passed; the generated net472 consumer uses net462 core assets and its assembly-qualified configuration type.
Native SDK composed product $mstest: FullyQualifiedName~PackagedAppNativeDotnetTestTests.NativeDotnetTest_ 10/10 passed with SDK 10.0.401.

Focused source-unit commands also passed:

.\.dotnet\dotnet.exe test --project test\UnitTests\TestFramework.UnitTests\TestFramework.UnitTests.csproj -c Release --no-build --treenode-filter '/*/*/TestContextTests/*' -p:UsingDotNetTest=true --no-artifact-post-processing
# Passed: 20/20 across net48/net10/net11/WinUI.
.\artifacts\bin\TestFramework.UnitTests\Release\net10.0-windows10.0.18362.0\win-x64\Microsoft.VisualStudio.TestPlatform.TestFramework.UnitTests.exe --treenode-filter '/*/*/WinUIExtensionTests/*' --report-trx
# Passed: 6/6 existing WinUI lifecycle cases.
.\eng\bazel.ps1 test //:sdk_package_tests --jobs=2 --test_output=errors
# Passed: native SDK contract target.
.\eng\bazel\windows\validate.ps1 -ArtifactsDirectory $run
# Passed: 5 runtime probes, 2 targeting/asset-selection tests, identical shared-core hashes.
.\eng\bazel.ps1 build //:mstest_uwp_package //:mstest_winui_package --jobs=2 --noshow_progress --show_result=0
# Passed: both native UI packages; maintained Assert-PackageLayout checks also pass.
.\eng\bazel.ps1 build //:mstest_platform_package_closure --jobs=2 --noshow_progress --show_result=0
# Exit 1: net462 PlatformServices CS0234, before full layout/ordinary consumer execution; see gap below.
python .github\scripts\test_check_localization.py
# Passed: 41 tests.
python .github\scripts\check_localization.py
# Passed: 364 catalogs.

The corrected shipping snapshot reexecutes the same defined follow-through: 177/177 green results (140 MSTest acceptance, 11 MTP acceptance, 26 source units), exit 0/zero skips. Independent execution gates reconcile all 151 acceptance identities. The separately repeated 12-case boundary proof is not double-counted. Binary logs, independent expected identities, TRX, frozen shipping hashes and red/green packages are retained locally in the task evidence, not uploaded; the maintained decision record contains the accessible readable results, commands and package hashes. No failed bootstrap, compile, runtime-install, zero-test or skipped result is credited as behavioral proof.

Gaps: no live CI result is claimed here; x86/ARM64 app layouts build but actual activation is x64; no servicing-branch backport is enabled; IDE/live external UI surfaces and unrelated WinApp CLI interoperability are not asserted by these package-boundary runs. Native Bazel Windows probes, targeting tests and modern UI archives pass, but the full native package closure stops on net462 PlatformServices CS0234: missing System.Reflection.Metadata/PortableExecutable references. The imports and missing native dependency are unchanged in the prerequisite (static comparison, not an executed pristine-baseline proof). Ordinary native package consumer execution remains unavailable; no unrelated native repair is included.

Test-value evidence

The shipping production/test snapshot is 33faf4889ca048ccdcb508c2088b15dd5f1efd21, based on e1c66e5cbfa844384a59343c3727821f97e2a09a. The original runtime/test contract files are byte-identical to 51457e73fbb982343390f33e5bb5c884361625ab, and their nine cases reexecute in the final selection. The original comparison preserves the implementation/test patch (40A24B318FBC73958041B198553CFCA92956665BAF6EEFEC788E9A2E7092937D) in an isolated worktree outside the repository ancestor tree. The buildable fault patch (314F18C1C3B184930923EC5949C7722FE84CAB039D635943980B7506CE81E9E9) makes the UI directory getter read its bag and changes the deployment guard's OR to AND. Both UI NuGets are rebuilt/repacked; consumers use distinct effective caches.

Exact retained selector: FullyQualifiedName~CoreFrameworkAssemblyTests|FullyQualifiedName~WinUITests.DeploymentItemsFailBeforeBodiesIncludingInheritedAttributes, using the acceptance command above.

Contract / exact test Without correct behavior Restored correct behavior
PackedConsumersUseSharedCoreAndSelectedUiPackage Executed: 4 UI cases fail the intended null assertion with TestRunDirectory = "must-not-be-a-directory"; 2 ordinary cases pass. Same 6 cases pass.
DeploymentItemsFailBeforeBodiesIncludingInheritedAttributes Executed: reflection, Rooting and ReflectionFree fail the intended unsupported-message/canary assertion because DEPLOYMENT_BODY_EXECUTED is observed. Same 3 cases pass.

Red: 9 executed, 7 intended failures, 2 ordinary passes, 0 skips, exit 2. Restored green: identical 9 executed, 9 passed, 0 skips, exit 0, after byte-exact source restoration and repacking.

Resolved-closure/exact-version correction: retain the same 12 cases selected by FullyQualifiedName~SdkTests.ExplicitPackages_RejectConflictingAdaptersBeforeCompilation|FullyQualifiedName~WindowsApplicationModelPackageTests.PackedUIFramework_OwnsItsPayloadWithoutAnotherAdapter. On the preceding package snapshot, six excluded-build/transitive conflict cases wrongly reach successful PrepareForBuild, and three nuspec cases observe a bare minimum instead of [5.0.0-dev]: 12 executed, 9 intended assertion failures, 3 direct controls passed, 0 skips, exit 2. After the corrected pack: identical 12/12 passed, 0 skips, exit 0. Retained test patch SHA-256: 733315AC5F3A0654FAC0A8BF7600F72C3B933212488BC9D8E365B5077CFC7296. Both package states and reports are preserved under the task's boundary evidence. Other package/SDK coverage has no general fault campaign; this proof is not generalized to unexecuted faults or intermediate commits.

Make TestFramework the shared core package owner and isolate each Windows
application model's UI attributes, adapters, build assets and satellites.
Update SDK/helper, metapackage, sample and native-build consumers while
preserving historical API snapshots and existing app activation ownership.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 12, 2026 16:26
@github-actions github-actions Bot added the state/needs-review Awaiting review from the team. label Nov 12, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Test quality review — PR #12435

Compared merge base e1c66e5cbfa844384a59343c3727821f97e2a09a with head 00428d48c212cf3630dcf6fa31d131c5ae745c98. Evidence applies to this head, not every intermediate commit.

Test-value evidence

This workflow is read-only and runs no tests. Everything below is a static assessment or an evidence gap; none of it is executed proof.

Contract Test Evidence
UI packages use the shared core, and UI directory getters return null CoreFrameworkAssemblyTests.PackedConsumersUseSharedCoreAndSelectedUiPackage The PR body reports an executed red/green run (7 intended failures, then 9 passes) against a fault patch. I could not check the records, so this is an unverified author claim.
[DeploymentItem] fails before the body, including inherited use WinUITests.DeploymentItemsFailBeforeBodiesIncludingInheritedAttributes The DEPLOYMENT_BODY_EXECUTED canary is a decisive assertion that would catch an unguarded body. Execution is an unverified author claim.
Conflicting adapter pairs are rejected, and the core dependency is exactly [version] SdkTests.ExplicitPackages_RejectConflictingAdaptersBeforeCompilation, WindowsApplicationModelPackageTests.PackedUIFramework_OwnsItsPayloadWithoutAnotherAdapter Same: the PR reports 9 intended failures and 12 passes. I could not check the records.
SDK application-model composition, modern UWP and package layout tests Remaining new tests in SdkTests*, ModernUwpTests, ClassicUwpTests, WindowsApplicationModelPackageTests Static prediction only. The assertions are on package identity and layout. The PR states there is no general fault campaign beyond the 12 cases above.
Bazel, .bzl, PowerShell, .slnx/.slnf and docs changes n/a Not applicable to executable test-value assessment. Native Bazel package-closure validation is acknowledged in the PR as failing on net462 PlatformServices (unchanged from the prerequisite).

Gaps: the PR reports no live CI result, and no paired execution records were available to me. The 165 changed source files and 173 changed files were not individually traced beyond these grouped contracts.

🧵 Parallel safety

STATUS: CLEAN. No assembly's parallelization configuration changed, and there were no findings. A=0, B=0, C=0, D=0.

  • ClassicUwpTests, ModernUwpTests and PackagedWinUITests keep [DoNotParallelize].
  • TESTFX_RUN_WINDOWS_APP_MODEL_TESTS is only read, in AcceptanceTestBase.cs.
  • WindowsApplicationModelTestTools edits are static data only.
  • Limitation: the specialist did not trace changed generated-asset source regions in UnpackagedWinUITests, WinUITests and SdkTests* beyond grepping for DoNotParallelize, env vars and static state.

Per-test assessment

Pseudo-mutation evidence below consists of static predictions, not executed mutation results. Per-test grading with the grade-tests rubric was not completed for the 18 changed test files because of review budget. Rows are Uncertain rather than graded; no inline findings were published.

Result Quality Test Notes How to improve
Uncertain — new CoreFrameworkAssemblyTests.PackedConsumersUseSharedCoreAndSelectedUiPackage Not graded in this run. Per-test grading needs a full pass with the production entry point and body.
Uncertain — new WinUITests.DeploymentItemsFailBeforeBodiesIncludingInheritedAttributes Not graded in this run. Per-test grading needs a full pass with the production entry point and body.
Uncertain — new SdkTests.ExplicitPackages_RejectConflictingAdaptersBeforeCompilation Not graded in this run. Per-test grading needs a full pass with the production entry point and body.
Uncertain — new WindowsApplicationModelPackageTests.PackedUIFramework_OwnsItsPayloadWithoutAnotherAdapter Not graded in this run. Per-test grading needs a full pass with the production entry point and body.
Uncertain — new ModernUwpTests.ModernUwp_ConsumesUwpAssets_AndRunsPlainAndUiTestsThroughMtp Not graded in this run. Per-test grading needs a full pass with the production entry point and body.
Uncertain — new other SdkTests, WindowsApplicationModelPackageTests (about 18 more methods) Not graded in this run. Per-test grading needs a full pass with the production entry point and body.

<sub>This advisory review is heuristic and non-blocking.

Re-run the combined review with /review-tests, or only the parallel-safety specialist with /parallel-audit.</sub>

🤖 Automated content by GitHub Copilot. Generated by the Test Quality Review on PR (on open / sync) workflow. · copilot · auto · ~57 AIC · ⌖ ~1 AIC · ⊞ 8.1K

@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Nov 12, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Result: no inline findings. This is not an all-clear. The PR is very large (173 files, ~981 KB diff). My review was limited and I did not confirm any defect.

What I checked

  • The PR description and its evidence plan.
  • The new Sdk.targets application-model selection and validation logic. It looked consistent: the model is chosen per inner TFM, conflicting UWP/WinUI settings produce errors, and UseWinUI takes precedence.
  • The layout of the new MSTest.Uwp project.

What I did not check

  • I could not read the saved diff in bulk, because shell access to the payload file was denied in this environment. The per-file patches, the Bazel/PowerShell tooling, the C# test changes and the API-history snapshots were not reviewed line by line.
  • Public API files, localization and .xlf changes, TFM and polyfill correctness for the net462 and uap10.0.16299 targets, and the removal of TestFramework.Extensions were not examined in depth.

Points for the human reviewers

  1. Known Bazel failure. The description says //:mstest_platform_package_closure fails on net462 PlatformServices with CS0234 (missing System.Reflection.Metadata / PortableExecutable references). The ordinary native package consumer therefore never runs. It attributes this to the prerequisite PR but only by static comparison. Please confirm the failure is not introduced by this PR's mstest-packages.bzl/mstest.bzl changes before merge.
  2. No live CI result is claimed. x86 and ARM64 app layouts were built but never activated. The description lists no servicing-branch backport.
  3. Next-major breaking change. Consumers of MSTest.TestFramework.Extensions.dll must migrate package and assembly references. Confirm that release notes and the migration guidance cover this, since the PR adds no migration analyzer.
  4. UI behavior change. UI-host directory getters now return null, and unsupported [DeploymentItem] use fails before the test body. This is covered by the red/green evidence in the description, which I could not re-run.
  5. Test-value evidence. The description reports 9 executed, 7 intended failures with the fault applied, and 9 passed after restoring the behavior. These results were not independently reproduced here.

@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Nov 12, 2026
@github-actions github-actions Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Nov 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Hosting still publishes a dependency on the ordinary test adapter, causing UI applications that add Hosting to fail the new adapter-composition validation; compatible dependencies and a packed UI-plus-Hosting regression case are needed.

1 open issue
What changed in this PR

This PR implements the package split described in #7225, following the core API moves in #12412 and #12428. It retires Extensions in favor of a shared MSTest core and explicit UWP/WinUI packages, with an intentional next-major migration requiring recompilation.

Changes:

  • Introduces platform-specific packages containing UI APIs, matching adapters, and localized resources.
  • Updates SDK selection, consumers, samples, and build infrastructure for the new package boundaries.
  • Adds UI directory/deployment behavior checks and preserves retired API records as inert history.

Test-value evidence: The description reports revision-bound counterfactual and restored-green results for shipping snapshot 33faf488, retained in delivery head 00428d48. Those executions were not independently verified here; review validation was static.

File Description
TestFx.slnx Replaces Extensions with UI projects.
test/​Utilities/​Microsoft.Testing.TestInfrastructure/​AcceptanceSourceGen.cs Updates the explanatory assembly example only.
test/​UnitTests/​TestFramework.UnitTests/​TestFramework.UnitTests.csproj References core and WinUI components.
test/​UnitTests/​TestFramework.UnitTests/​Extensions/​WinUIExtensionTests.cs Loads AppModel from PlatformServices.
test/​UnitTests/​TestFramework.UnitTests/​Extensions/​TestContextTests.cs Exercises shared directory APIs on WinUI.
test/​UnitTests/​MSTestAdapter.UnitTests/​MSTestAdapter.UnitTests.csproj Removes the retired Extensions reference.
test/​UnitTests/​MSTestAdapter.PlatformServices.UnitTests/​MSTestAdapter.PlatformServices.UnitTests.csproj Uses core directly across targets.
test/​UnitTests/​MSTest.SourceGeneration.UnitTests/​MSTest.SourceGeneration.UnitTests.csproj Replaces Extensions with core.
test/​UnitTests/​MSTest.Analyzers.UnitTests/​MSTest.Analyzers.UnitTests.csproj Replaces Extensions with core.
test/​IntegrationTests/​MSTest.Acceptance.IntegrationTests/​WindowsApplicationModelTestTools.cs Checks explicit UI package asset paths.
test/​IntegrationTests/​MSTest.Acceptance.IntegrationTests/​UnpackagedWinUITests.cs Uses WinUI package and checks null directories.
test/​IntegrationTests/​MSTest.Acceptance.IntegrationTests/​SourceGenerationNonAotTests.cs Checks private adapter dependency behavior.
test/​IntegrationTests/​MSTest.Acceptance.IntegrationTests/​FrameworkTargetingTests.cs Updates core import and assembly expectations.
test/​IntegrationTests/​MSTest.Acceptance.IntegrationTests/​CppCliVSTestTests.cs Removes generated Extensions reference.
test/​IntegrationTests/​MSTest.Acceptance.IntegrationTests/​CppCliMtpTests.cs Removes generated Extensions reference.
test/​IntegrationTests/​MSTest.Acceptance.IntegrationTests/​ClassicUwpTests.cs Uses UWP package and checks directory behavior.
test/​IntegrationTests/​Microsoft.Testing.Platform.Acceptance.IntegrationTests/​PackagedWinUITests.cs Updates WinUI composition and directory checks.
test/​Directory.Build.targets Removes obsolete coverage assembly mapping.
src/​TestFramework/​TestFramework/​TestContext.cs Exposes shared directory APIs and documents UI behavior.
src/​TestFramework/​TestFramework/​PACKAGE.md Documents shared core and migration.
src/​TestFramework/​TestFramework/​MSTest.TestFramework.targets Supplies implicit MSTest namespace imports.
src/​TestFramework/​TestFramework/​Attributes/​DeploymentItemAttribute.cs Exposes modern UI API and documents rejection.
src/​TestFramework/​TestFramework.Windows.UIAutomation/​TestFramework.Windows.UIAutomation.csproj References core instead of Extensions.
src/​TestFramework/​TestFramework.Extensions/​buildTransitive/​net10.0AndLater/​MSTest.TestFramework.targets Removes property-driven UI assembly replacement.
src/​TestFramework/​TestFramework.Extensions/​build/​uap10.0/​MSTest.TestFramework.targets Removes obsolete UWP import wrapper.
src/​TestFramework/​TestFramework.Extensions/​build/​netstandard2.0/​MSTest.TestFramework.targets Removes obsolete .NET Standard wrapper.
src/​TestFramework/​TestFramework.Extensions/​build/​net462/​MSTest.TestFramework.targets Removes obsolete .NET Framework wrapper.
src/​TestFramework/​TestFramework.Extensions/​build/​net11.0/​MSTest.TestFramework.targets Removes obsolete .NET 11 wrapper.
src/​TestFramework/​TestFramework.Extensions/​build/​net10.0/​MSTest.TestFramework.targets Removes obsolete .NET 10 wrapper.
src/​TestFramework/​PlatformPackage/​PlatformPackage.targets Packs UI payloads and pins matching core versions.
src/​TestFramework/​PlatformPackage/​PlatformPackage.props Shares UI project dependencies and packaging settings.
src/​TestFramework/​PlatformPackage/​MSTest.Platform.props Defines package-local payload roots and markers.
src/​TestFramework/​MSTest.WinUI/​Resources/​xlf/​FrameworkExtensionsMessages.zh-Hant.xlf Adds Traditional Chinese WinUI catalog.
src/​TestFramework/​MSTest.WinUI/​Resources/​xlf/​FrameworkExtensionsMessages.zh-Hans.xlf Adds Simplified Chinese WinUI catalog.
src/​TestFramework/​MSTest.WinUI/​Resources/​xlf/​FrameworkExtensionsMessages.tr.xlf Adds Turkish WinUI catalog.
src/​TestFramework/​MSTest.WinUI/​Resources/​xlf/​FrameworkExtensionsMessages.ru.xlf Adds Russian WinUI catalog.
src/​TestFramework/​MSTest.WinUI/​Resources/​xlf/​FrameworkExtensionsMessages.pt-BR.xlf Adds Brazilian Portuguese WinUI catalog.
src/​TestFramework/​MSTest.WinUI/​Resources/​xlf/​FrameworkExtensionsMessages.pl.xlf Adds Polish WinUI catalog.
src/​TestFramework/​MSTest.WinUI/​Resources/​xlf/​FrameworkExtensionsMessages.ko.xlf Adds Korean WinUI catalog.
src/​TestFramework/​MSTest.WinUI/​Resources/​xlf/​FrameworkExtensionsMessages.ja.xlf Adds Japanese WinUI catalog.
src/​TestFramework/​MSTest.WinUI/​Resources/​xlf/​FrameworkExtensionsMessages.it.xlf Adds Italian WinUI catalog.
src/​TestFramework/​MSTest.WinUI/​Resources/​xlf/​FrameworkExtensionsMessages.fr.xlf Adds French WinUI catalog.
src/​TestFramework/​MSTest.WinUI/​Resources/​xlf/​FrameworkExtensionsMessages.es.xlf Adds Spanish WinUI catalog.
src/​TestFramework/​MSTest.WinUI/​Resources/​xlf/​FrameworkExtensionsMessages.de.xlf Adds German WinUI catalog.
src/​TestFramework/​MSTest.WinUI/​Resources/​xlf/​FrameworkExtensionsMessages.cs.xlf Adds Czech WinUI catalog.
src/​TestFramework/​MSTest.WinUI/​PublicAPI/​PublicAPI.Unshipped.txt Records WinUI public APIs.
src/​TestFramework/​MSTest.WinUI/​PublicAPI/​PublicAPI.Shipped.txt Initializes shipped public API baseline.
src/​TestFramework/​MSTest.WinUI/​Properties/​AssemblyInfo.cs Declares supported Windows platform.
src/​TestFramework/​MSTest.WinUI/​PACKAGE.md Documents WinUI package usage and migration.
src/​TestFramework/​MSTest.WinUI/​MSTest.WinUI.csproj Defines the explicit WinUI package.
src/​TestFramework/​MSTest.WinUI/​InternalAPI/​InternalAPI.Unshipped.txt Records WinUI internal APIs.
src/​TestFramework/​MSTest.WinUI/​InternalAPI/​InternalAPI.Shipped.txt Initializes shipped internal API baseline.
src/​TestFramework/​MSTest.WinUI/​Attributes/​WinUITestTargetAttribute.cs Places application-target attribute in WinUI assembly.
src/​TestFramework/​MSTest.Uwp/​PublicAPI/​PublicAPI.Unshipped.txt Records UWP public APIs.
src/​TestFramework/​MSTest.Uwp/​PublicAPI/​PublicAPI.Shipped.txt Initializes shipped public API baseline.
src/​TestFramework/​MSTest.Uwp/​Properties/​MSTest.Uwp.rd.xml Updates runtime-directive library identity.
src/​TestFramework/​MSTest.Uwp/​Properties/​AssemblyInfo.cs Retains UWP assembly metadata.
src/​TestFramework/​MSTest.Uwp/​PACKAGE.md Documents classic and modern UWP usage.
src/​TestFramework/​MSTest.Uwp/​MSTest.Uwp.csproj Defines the explicit UWP package.
src/​TestFramework/​MSTest.Uwp/​InternalAPI/​InternalAPI.Unshipped.txt Records UWP internal APIs.
src/​TestFramework/​MSTest.Uwp/​InternalAPI/​InternalAPI.Shipped.txt Initializes shipped internal API baseline.
src/​TestFramework/​MSTest.Uwp/​Attributes/​UITestMethodAttribute.cs Places dispatcher-based UI tests in UWP assembly.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​README.md Explains inert API history and migration.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​PublicAPI/​uap10.0.16299/​PublicAPI.Unshipped.txt.history Archives UWP unshipped public API record.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​PublicAPI/​uap10.0.16299/​PublicAPI.Shipped.txt.history Archives UWP shipped public API record.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​PublicAPI/​PublicAPI.Unshipped.txt.history Archives common public API removals.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​PublicAPI/​PublicAPI.Shipped.txt.history Archives common shipped public APIs.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​PublicAPI/​netstandard2.0/​PublicAPI.Unshipped.txt.history Archives .NET Standard public API removals.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​PublicAPI/​netstandard2.0/​PublicAPI.Shipped.txt.history Archives .NET Standard shipped public APIs.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​PublicAPI/​net10.0/​PublicAPI.Unshipped.txt.history Archives .NET 10 public API removals.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​PublicAPI/​net10.0/​PublicAPI.Shipped.txt.history Archives .NET 10 shipped public APIs.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​PublicAPI/​net10.0-windows10.0.18362.0/​PublicAPI.Unshipped.txt.history Archives WinUI unshipped public API record.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​PublicAPI/​net10.0-windows10.0.18362.0/​PublicAPI.Shipped.txt.history Archives WinUI shipped public APIs.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​PublicAPI/​net10.0-windows10.0.17763.0/​PublicAPI.Unshipped.txt.history Archives modern UWP unshipped public API record.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​PublicAPI/​net10.0-windows10.0.17763.0/​PublicAPI.Shipped.txt.history Archives modern UWP shipped public APIs.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​uap10.0.16299/​InternalAPI.Unshipped.txt.history Archives UWP unshipped internal API record.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​uap10.0.16299/​InternalAPI.Shipped.txt.history Archives UWP shipped internal API record.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​netstandard2.0/​InternalAPI.Unshipped.txt.history Archives .NET Standard unshipped internal record.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​netstandard2.0/​InternalAPI.Shipped.txt.history Archives .NET Standard shipped internal record.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​net462/​InternalAPI.Unshipped.txt.history Archives .NET Framework internal API removals.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​net462/​InternalAPI.Shipped.txt.history Archives .NET Framework shipped internal APIs.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​net10.0/​InternalAPI.Unshipped.txt.history Archives .NET 10 unshipped internal record.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​net10.0/​InternalAPI.Shipped.txt.history Archives .NET 10 shipped internal record.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​net10.0-windows10.0.18362.0/​InternalAPI.Unshipped.txt.history Archives WinUI unshipped internal record.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​net10.0-windows10.0.18362.0/​InternalAPI.Shipped.txt.history Archives WinUI shipped internal APIs.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​net10.0-windows10.0.17763.0/​InternalAPI.Unshipped.txt.history Archives modern UWP unshipped internal record.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​net10.0-windows10.0.17763.0/​InternalAPI.Shipped.txt.history Archives modern UWP shipped internal APIs.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​InternalAPI.Unshipped.txt.history Archives common internal API removals.
src/​TestFramework/​APIHistory/​TestFramework.Extensions/​InternalAPI/​InternalAPI.Shipped.txt.history Archives common shipped internal APIs.
src/​Package/​MSTest/​PACKAGE.md Documents metapackage limits for modern UI.
src/​Package/​MSTest/​MSTest.csproj Selects UWP dependency for classic UWP.
src/​Package/​MSTest.Sdk/​Sdk/​VSTest/​VSTest.targets Uses the selected adapter package.
src/​Package/​MSTest.Sdk/​Sdk/​Runner/​NativeAOT.targets Uses selected adapter for runtime hooks.
src/​Package/​MSTest.Sdk/​Sdk/​Runner/​Common.targets Applies application-model settings to hosting.
src/​Package/​MSTest.Sdk/​Sdk/​Runner/​ClassicEngine.targets Uses the selected adapter package.
src/​Package/​MSTest.Sdk/​PACKAGE.md Documents model selection and helper composition.
src/​Adapter/​MSTestAdapter.PlatformServices/​Services/​TestContextImplementation.Properties.cs Returns null for all UI-host directories.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​xlf/​Resource.zh-Hant.xlf Adds UI deployment diagnostic catalog entry.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​xlf/​Resource.zh-Hans.xlf Adds UI deployment diagnostic catalog entry.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​xlf/​Resource.tr.xlf Adds UI deployment diagnostic catalog entry.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​xlf/​Resource.ru.xlf Adds UI deployment diagnostic catalog entry.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​xlf/​Resource.pt-BR.xlf Adds UI deployment diagnostic catalog entry.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​xlf/​Resource.pl.xlf Adds UI deployment diagnostic catalog entry.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​xlf/​Resource.ko.xlf Adds UI deployment diagnostic catalog entry.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​xlf/​Resource.ja.xlf Adds UI deployment diagnostic catalog entry.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​xlf/​Resource.it.xlf Adds UI deployment diagnostic catalog entry.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​xlf/​Resource.fr.xlf Adds UI deployment diagnostic catalog entry.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​xlf/​Resource.es.xlf Adds UI deployment diagnostic catalog entry.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​xlf/​Resource.de.xlf Adds UI deployment diagnostic catalog entry.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​xlf/​Resource.cs.xlf Adds UI deployment diagnostic catalog entry.
src/​Adapter/​MSTestAdapter.PlatformServices/​Resources/​Resource.resx Defines unsupported UI deployment message.
src/​Adapter/​MSTestAdapter.PlatformServices/​MSTestAdapter.PlatformServices.csproj References shared core directly.
src/​Adapter/​MSTestAdapter.PlatformServices/​InternalAPI/​InternalAPI.Unshipped.txt Tracks AppModel and directory overrides.
src/​Adapter/​MSTestAdapter.PlatformServices/​Execution/​TestMethodRunner.cs Rejects UI deployment attributes before execution.
src/​Adapter/​MSTest.TestAdapter/​PackageDependencies.props Centralizes adapter package dependencies.
src/​Adapter/​MSTest.TestAdapter/​PACKAGE.md Directs UI consumers to explicit packages.
src/​Adapter/​MSTest.TestAdapter/​buildTransitive/​uwp/​MSTest.TestAdapter.targets Uses package-local payloads and validates composition.
src/​Adapter/​MSTest.TestAdapter/​buildTransitive/​uwp/​MSTest.TestAdapter.props Removes superseded UWP properties file.
src/​Adapter/​MSTest.TestAdapter/​buildTransitive/​common/​MSTest.TestAdapter.props Marks ordinary adapter composition.
src/​Adapter/​MSTest.TestAdapter/​build/​uap10.0/​MSTest.TestAdapter.targets Removes ordinary adapter UWP wrapper.
src/​Adapter/​MSTest.TestAdapter/​build/​uap10.0/​MSTest.TestAdapter.props Removes ordinary adapter UWP wrapper.
src/​Adapter/​MSTest.Extensions.Hosting/​MSTest.Extensions.Hosting.csproj Publishes the direct core dependency.
samples/​public/​WinUIVSTestApp/​WinUIVSTestApp.csproj Migrates sample to MSTest.WinUI.
samples/​public/​UwpVSTestApp/​UwpVSTestApp.csproj Migrates sample to MSTest.Uwp.
samples/​public/​ClassicUwpMtpApp/​ClassicUwpMtpApp.csproj Copies shared core and UWP assembly.
NonWindowsTests.slnf Removes retired Extensions project.
MSTest.slnf Includes explicit UI projects.
eng/​verify-nupkgs.ps1 Updates expected package file counts.
eng/​mutation-testing/​modules.json Replaces Extensions inventory with UI exclusions.
eng/​bazel/​windows/​validate-app-model.ps1 Checks append-only provenance and current frameworks.
eng/​bazel/​windows/​AppModelHost.cs Writes unique provenance reports and appends paths.
eng/​bazel/​validate.ps1 Reports .NET 10/11 validation scope.
eng/​bazel/​validate-sdk-packages.ps1 Adds explicit UI model evaluation cases.
eng/​bazel/​validate-packages.ps1 Aligns validation with .NET 10/11.
eng/​bazel/​tests.bzl Removes Extensions dependencies from tests.
eng/​bazel/​SdkPackageTool.cs Updates metapackage dependency mapping.
eng/​bazel/​sdk-packages.bzl Updates SDK test dependencies and count floor.
eng/​bazel/​samples.bzl Uses shared core and .NET 10 samples.
eng/​bazel/​reference-alias-tests.bzl Updates framework and removes Extensions dependency.
eng/​bazel/​MSTestPackageVersion.cs Supports exact UI-to-core version constraints.
eng/​bazel/​mstest.bzl Removes Extensions library and dependent references.
eng/​bazel/​mstest-consumer/​NativePackageTests.cs Checks shared-core identity and unique evidence files.
eng/​bazel/​extensions.bzl Removes Hosting's native Extensions dependency.
eng/​bazel/​defs.bzl Limits portable frameworks to .NET 10/11.
eng/​bazel/​compatibility.bzl Removes Extensions compatibility targets.
BUILD.bazel Removes retired Extensions build references.
.github/​copilot-instructions.md Updates repository-layout documentation only.

Review effort: Balanced

<ProjectReference Include="$(RepoRoot)src\TestFramework\TestFramework\TestFramework.csproj" PrivateAssets="all" />
<!-- Preserve the dependency on the owning MSTest.TestFramework package. -->
<ProjectReference Include="$(RepoRoot)src\TestFramework\TestFramework.Extensions\TestFramework.Extensions.csproj" />
<ProjectReference Include="$(RepoRoot)src\TestFramework\TestFramework\TestFramework.csproj" />
@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Nov 12, 2026
@github-actions github-actions Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Nov 12, 2026
"Microsoft.Testing.Extensions.TrxReport.Abstractions",
];
Assert.AreSequenceEqual(names, assemblies.EnumerateObject().Select(property => property.Name).ToArray(), SequenceOrder.InAnyOrder);
Assert.IsFalse(File.Exists(Path.Combine(AppContext.BaseDirectory, "MSTest.TestFramework.Extensions.dll")));
string evidence = Environment.GetEnvironmentVariable("TESTFX_BAZEL_CONSUMER_EVIDENCE")
?? throw new InvalidOperationException("The consumer evidence path was not supplied.");
File.WriteAllText(evidence, JsonSerializer.Serialize(new
string reportPath = Path.Combine(Path.GetDirectoryName(Path.GetFullPath(evidence))!, "loaded-assemblies-" + Guid.NewGuid().ToString("N") + ".json");
};
string json = JsonSerializer.Serialize(report);
File.WriteAllText(Path.Combine(AppContext.BaseDirectory, "native-app-model.json"), json);
string reportPath = Path.Combine(AppContext.BaseDirectory, "native-app-model-" + Guid.NewGuid().ToString("N") + ".json");
writer.Write(json);
}

File.AppendAllLines(Path.Combine(AppContext.BaseDirectory, "native-app-model.paths"), [reportPath]);
#else
#error A Windows library probe scenario must be selected.
#endif
if (File.Exists(Path.Combine(AppContext.BaseDirectory, "MSTest.TestFramework.Extensions.dll")))
failIfReturnValueIsNotZero: false,
cancellationToken: TestContext.CancellationToken);
using var assets = JsonDocument.Parse(
await File.ReadAllTextAsync(Path.Combine(asset.TargetAssetPath, "obj", "project.assets.json"), TestContext.CancellationToken));
.PatchCodeWithReplace("$MSBuildSdkExtrasVersion$", MSBuildSdkExtrasVersion)
.PatchCodeWithReplace("$MSTestVersion$", MSTestVersion));
VisualStudioTestTools tools = await WindowsApplicationModelTestTools.LocateClassicUwpVisualStudioToolsAsync(TestContext.CancellationToken);
string projectPath = Path.Combine(testAsset.TargetAssetPath, "ClassicUwp.csproj");
VisualStudioTestTools tools = await WindowsApplicationModelTestTools.LocateClassicUwpVisualStudioToolsAsync(TestContext.CancellationToken);
string projectPath = Path.Combine(testAsset.TargetAssetPath, "ClassicUwp.csproj");
BoundedCommandLineResult result = await RunWindowsApplicationModelCommandAsync(
$"\"{tools.MSBuildPath}\" \"{projectPath}\" /restore /t:PrintClassicComposition /p:Configuration=Release /p:Platform=x64 /bl:\"{Path.Combine(testAsset.TargetAssetPath, "classic-uwp.binlog")}\"",

using TestAsset testAsset = await TestAsset.GenerateAssetAsync($"{applicationModel}HelperSdk", source);
DotnetMuxerResult result = await DotnetCli.RunAsync(
$"build \"{testAsset.TargetAssetPath}\" -c Release -bl:\"{Path.Combine(testAsset.TargetAssetPath, "helper.binlog")}\"",

await AssertResolvedMSTestCompositionAsync(testAsset.TargetAssetPath, targetFramework, expectedAdapterPackageId);
await AssertResolvedMSTestReferencesAsync(testAsset.TargetAssetPath, expectedAdapterPackageId);
string[] copyLocal = await File.ReadAllLinesAsync(Path.Combine(testAsset.TargetAssetPath, "copy-local-assets.txt"), TestContext.CancellationToken);
@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Nov 12, 2026
@github-actions github-actions Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Final test-triage resolution — Azure Pipelines build 1677865

Analysis mode: final (completed build). Triggering check: microsoft.testfx.

Conclusion: no test failures to triage. The build result is failed, but the collected evidence has 0 test results (no failures, retries, or flaky tests). It also has 0 crash/hang diagnostics, 0 slow-test regressions, and no evidence collection failures (evidenceIncomplete: false).

The only failed timeline record is the "Build repository with BuildXL" task. That is a build failure, which is outside this triage's scope; Build Failure Analysis owns it. Test history for the previous 30 days has no matching candidates.

No issue was created. Next step: review the BuildXL build step failure for this PR. This does not clear the tests, because none were reported as run in the collected evidence.

🤖 Automated content by GitHub Copilot. Generated by the Pipeline Test Triage workflow. · copilot · auto · ~20 AIC · ⌖ ~1 AIC · ⊞ 10.1K

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Build Failure Analysis

Summary — Six available build legs failed for three root causes: the public samples reference new UI packages that are unavailable at their pinned MSTest version, Linux pack misplaces a .targets file because of a backslash package path, and the WinUI unit-test target no longer references the assembly containing AppContainer APIs.

Two mechanical fixes were posted as inline suggestions. The Windows application-model acceptance leg failed without publishing a binlog, so additional errors in that leg could not be analyzed.

Root cause 1: public samples consume unavailable package IDs

samples/public/Directory.Build.props pins MSTestVersion to 4.5.3, while this PR changes three samples to consume the newly introduced MSTest.Uwp / MSTest.WinUI packages. Restore reports that those IDs do not exist in the configured dotnet-public or test-tools sources; the classic UWP sample does not reference MSTest.Uwp for restore at all and later tries to copy its missing 4.5.3 assembly directly from the NuGet cache.

Affected files / errors

Proposed fix

Choose one consistent package-provenance strategy for these public samples:

  1. Keep their existing 4.5.3-compatible MSTest.TestAdapter / MSTest.TestFramework references and classic extension asset paths until MSTest.Uwp and MSTest.WinUI are available from the sample feeds, then migrate the samples with the corresponding published version; or
  2. Change the Windows-samples build to restore these three projects from the PR's locally packed 5.0.0-ci packages, including an explicit MSTest.Uwp reference for ClassicUwpMtpApp.

The binlogs establish that the current version/source combination cannot restore, but do not establish which release-sequencing option is intended, so no speculative version suggestion was posted.

Root cause 2: Linux pack receives a Windows-style package path

src/TestFramework/TestFramework/TestFramework.csproj:66 sets PackagePath="buildTransitive\". The Linux binlog preserves that metadata exactly, while NuGet validates the conventional path buildTransitive/MSTest.TestFramework.targets; NU5129 is promoted to an error by repository-wide warnings-as-errors.

Proposed fix

Use the cross-platform NuGet package path buildTransitive/. An inline suggestion was posted on the changed line.

Root cause 3: WinUI unit tests lost the platform-framework reference

Both Windows Release and Debug fail at UITestMethodStartupWaitTests.cs:7 with CS0234 because Microsoft.VisualStudio.TestTools.UnitTesting.AppContainer now lives in MSTest.WinUI, but MSTestAdapter.PlatformServices.UnitTests.csproj:26 removed the old extensions reference without adding the replacement platform project.

Proposed fix

Add a conditional project reference to src/TestFramework/MSTest.WinUI/MSTest.WinUI.csproj for $(WinUiMinimum). An inline suggestion was posted on the changed project-reference line.


Build overview
  • 27 binlogs analyzed: 21 had no structured errors; 6 failed.
  • Windows samples: ClassicUwpMtpApp failed during copy; UwpVSTestApp and WinUIVSTestApp failed during restore.
  • Linux Release: TestFramework.csproj failed in GenerateNuspec with NU5129 after 407.2s.
  • Windows Release / Debug: MSTestAdapter.PlatformServices.UnitTests.csproj failed in CoreCompile with the same CS0234 after 825.6s / 838.8s.
  • Missing evidence: Windows application-model acceptance failed but published no binlog.
Actionable MSBuild errors (6)
Code Leg / project File:Line Message
MSB3030 Windows sample / ClassicUwpMtpApp.csproj Microsoft.Common.CurrentVersion.targets:5490 Could not copy mstest.uwp\4.5.3\...\MSTest.Uwp.dll because it was not found.
NU1101 Windows sample / UwpVSTestApp.sln UwpVSTestApp.csproj Unable to find package MSTest.Uwp in dotnet-public, test-tools.
NU1101 Windows sample / WinUIVSTestApp.sln WinUIVSTestApp.csproj Unable to find package MSTest.WinUI in dotnet-public, test-tools.
NU5129 Linux Release / TestFramework.csproj NuGet.Build.Tasks.Pack.targets:232 buildTransitive/MSTest.TestFramework.targets was not found.
CS0234 Windows Release / unit tests UITestMethodStartupWaitTests.cs:7 AppContainer does not exist in Microsoft.VisualStudio.TestTools.UnitTesting.
CS0234 Windows Debug / unit tests UITestMethodStartupWaitTests.cs:7 Same missing namespace/reference.

[Azure DevOps build]((dev.azure.com/redacted)


🤖 Generated by the Build Failure Analysis workflow using (a href="(dev.azure.com/redacted) · commit 00428d4

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · copilot · gpt56 · ~265 AIC · ⌖ ~22 AIC · ⊞ 36.6K · ◷

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · copilot · gpt56 · ~265 AIC · ⌖ ~22 AIC · ⊞ 36.6K


<ItemGroup>
<ProjectReference Include="$(RepoRoot)src\Analyzers\MSTest.Analyzers.Package\MSTest.Analyzers.Package.csproj" PrivateAssets="none" ExcludeAssets="compile;runtime" />
<None Include="MSTest.TestFramework.targets" Pack="true" PackagePath="buildTransitive\" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 NU5129 — On Linux, NuGet preserves this backslash in the package path, so the file is not recognized as buildTransitive/MSTest.TestFramework.targets and pack fails under warnings-as-errors.

Suggested change
<None Include="MSTest.TestFramework.targets" Pack="true" PackagePath="buildTransitive\" />
<None Include="MSTest.TestFramework.targets" Pack="true" PackagePath="buildTransitive/" />


<ItemGroup>
<ProjectReference Include="$(RepoRoot)src\TestFramework\TestFramework\TestFramework.csproj" Condition=" '$(IsNetCoreApp)' != 'true' " />
<ProjectReference Include="$(RepoRoot)src\TestFramework\TestFramework\TestFramework.csproj" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 CS0234 — UITestMethodAttribute moved into the new MSTest.WinUI assembly, but the WinUI test target now references only the core framework project. Add the platform project for the WinUI TFM so the existing WIN_UI tests can resolve Microsoft.VisualStudio.TestTools.UnitTesting.AppContainer.

Suggested change
<ProjectReference Include="$(RepoRoot)src\TestFramework\TestFramework\TestFramework.csproj" />
<ProjectReference Include="$(RepoRoot)src\TestFramework\TestFramework\TestFramework.csproj" />
<ProjectReference Include="$(RepoRoot)src\TestFramework\MSTest.WinUI\MSTest.WinUI.csproj" Condition=" '$(TargetFramework)' == '$(WinUiMinimum)' " />

@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Nov 12, 2026
@github-actions github-actions Bot removed the state/needs-review Awaiting review from the team. label Nov 12, 2026
@github-actions github-actions Bot added the state/needs-review Awaiting review from the team. label Nov 12, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added state/needs-review Awaiting review from the team. and removed state/needs-review Awaiting review from the team. labels Nov 12, 2026
@github-actions github-actions Bot added state/approved Proposal approved; ready for implementation. and removed state/needs-review Awaiting review from the team. labels Nov 12, 2026
@Evangelink

Copy link
Copy Markdown
Member Author

Superseded by the focused replacement series, bottom to top:

  1. Use shared MSTest core in UI test hosts #12446 - shared-core UI runtime contract, retaining the existing package layout.
  2. Extract MSTest.Uwp and MSTest.WinUI packages #12450 - extract MSTest.Uwp and MSTest.WinUI and retire Extensions.
  3. Select and validate MSTest SDK application models #12452 - SDK/helper selection and composition policy.
  4. Add native Bazel parity for MSTest UI packages #12451 - native Bazel package parity.

Each PR has its own scope, validation record and explicit gaps. The original branch and commits are preserved for reference; no merge or Agent merge is requested.

@github-actions github-actions Bot removed the state/approved Proposal approved; ready for implementation. label Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants