[fmt,folly] backport '/utf-8 only if the compiler is MSVC at build time'

[aminya]

Backporting fmtlib/fmt#4159

Fixes #40912

• Changes comply with the maintainer guide.
• SHA512s are updated for each updated download.
• The "supports" clause reflects platforms that may be fixed by this new version.
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[miyanyan]

there's a folly patch when I update fmt to 11.0.2, https://github.com/microsoft/vcpkg/blob/master/ports/folly/fix-fmt11-cmake.patch

diff --git a/CMake/GenPkgConfig.cmake b/CMake/GenPkgConfig.cmake
index 0e93175..1637d9f 100644
--- a/CMake/GenPkgConfig.cmake
+++ b/CMake/GenPkgConfig.cmake
@@ -93,7 +93,7 @@ function(gen_pkgconfig_vars)
   # Set the output variables
   string(REPLACE ";" " " cflags "${cflags}")
   string(REPLACE ";" " " private_libs "${private_libs}")
-
+  string(REPLACE "<$<COMPILE_LANGUAGE:CXX>:/utf-8>" "/utf-8" cflags "${cflags}")
   # Since CMake 3.18 FindThreads may include a generator expression requiring
   # a target, which gets propagated to us through INTERFACE_COMPILE_OPTIONS.
   # Before CMake 3.19 there's no way to solve this in a general way, so we

I use string(REPLACE "<$<COMPILE_LANGUAGE:CXX>:/utf-8>" "/utf-8" cflags "${cflags}") to avoid cmake error, see facebook/folly#2250, so maybe this patch should be changed also

[WangWeiLin-MV]

As @miyanyan said,

maybe this patch should be changed also

[aminya]

I removed the folly patch. That patch would cause the same fmt error for folly. The current fmt patch is robust under LLVM or MSVC. I only added it for old CMake versions that do not support generator expressions via file(GENERATE

[BillyONeal]

Has the folly change been submitted to folly?

[aminya]

@BillyONeal Created a PR:
facebook/folly#2293

[WangWeiLin-MV]

Please resolve the git conflicts.

[Laro88]

Comment, this would be nice to have resolved properly, fmt is currently breaking out builds.

[aminya]

Conflicts fixed

[ysyecust]

Looking forward to merging it soon. Due to this problem, clang-tidy cannot be used normally on Windows if the fmt library is included.

[WangWeiLin-MV]

Just a suggestion

[aminya]

@WangWeiLin-MV I prefer to keep the setup simple. The next version of fmt will remove this patch anyway.

[WangWeiLin-MV]

The port fmt and folly usage tests pass with the following triplets:

• x64-linux
• x64-windows

[WangWeiLin-MV]

Tag reviewed for further review.

[Karma5s]

Still getting this error vcpkg_installed\x64-windows\x64-windows\include\fmt\base.h(458,28): error C2338: static_assert failed: 'Unicode support requires compiling with /utf-8' when compiling with MSVC following this tutorial
https://learn.microsoft.com/en-us/vcpkg/get_started/get-started-msbuild?pivots=shell-powershell