Skip to content

Remove LINQ/capture class allocations#270

Merged
AArnott merged 1 commit into
microsoft:mainfrom
davkean:RemoveCaptureClasses
Nov 29, 2021
Merged

Remove LINQ/capture class allocations#270
AArnott merged 1 commit into
microsoft:mainfrom
davkean:RemoveCaptureClasses

Conversation

@davkean
Copy link
Copy Markdown
Member

@davkean davkean commented Nov 24, 2021

This is a hot path during solution load.

image

This is a hot path during solution load.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #270 (e04c96d) into main (14c11e1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   89.63%   89.64%           
=======================================
  Files          87       87           
  Lines        6023     6028    +5     
=======================================
+ Hits         5399     5404    +5     
  Misses        624      624           
Impacted Files Coverage Δ
...ft.VisualStudio.Composition/LazyMetadataWrapper.cs 71.77% <100.00%> (ø)
...soft.VisualStudio.Composition/ReflectionHelpers.cs 71.14% <100.00%> (+0.49%) ⬆️
...timeExportProviderFactory+RuntimeExportProvider.cs 97.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c11e1...e04c96d. Read the comment docs.

@AArnott AArnott added this to the v17.1 milestone Nov 24, 2021
@AArnott AArnott requested a review from milopezc November 24, 2021 22:54
@davkean
Copy link
Copy Markdown
Member Author

davkean commented Nov 24, 2021

@AArnott Can you merge this in?

@AArnott AArnott merged commit 4263aeb into microsoft:main Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants