Skip to content

Improve error messages around part discovery#288

Merged
AArnott merged 3 commits into
microsoft:mainfrom
AArnott:fixes
Jan 19, 2022
Merged

Improve error messages around part discovery#288
AArnott merged 3 commits into
microsoft:mainfrom
AArnott:fixes

Conversation

@AArnott
Copy link
Copy Markdown
Member

@AArnott AArnott commented Jan 19, 2022

  • One particular error message gets improved.
  • Other error messages now get wrapped in another InnerException layer so that more context is available in the overall error message. Specifically, an error while scanning a member now reveals which member was being scanned.

@AArnott AArnott added this to the v17.2 milestone Jan 19, 2022
@AArnott AArnott requested a review from milopezc January 19, 2022 16:38
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #288 (1a6e182) into main (7205d37) will decrease coverage by 0.01%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   89.65%   89.63%   -0.02%     
==========================================
  Files          87       87              
  Lines        6088     6096       +8     
==========================================
+ Hits         5458     5464       +6     
- Misses        630      632       +2     
Impacted Files Coverage Δ
...mposition/Configuration/AttributedPartDiscovery.cs 95.91% <91.66%> (-0.91%) ⬇️
...osoft.VisualStudio.Composition/Strings.Designer.cs 69.04% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7205d37...1a6e182. Read the comment docs.

@AArnott AArnott merged commit 2bc6600 into microsoft:main Jan 19, 2022
@AArnott AArnott deleted the fixes branch January 19, 2022 21:13
AArnott pushed a commit that referenced this pull request Oct 30, 2024
Bumps [dotnet-coverage](https://github.com/microsoft/codecoverage) from 17.12.2 to 17.12.3.
- [Commits](https://github.com/microsoft/codecoverage/commits)

---
updated-dependencies:
- dependency-name: dotnet-coverage
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants