A few fixes to [OnImportsSatisfied] use#290
Merged
Merged
Conversation
In MEFv2, these would be found. In VS-MEF they were ignored unless the NonPublic flag was set. VS-MEF is meant to be compatible with V2 without that flag.
This includes API breaking changes, but all within the catalog/discovery system, which isn't considered critical since it's essentially for internal use only.
Codecov Report
@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 89.63% 89.14% -0.50%
==========================================
Files 87 87
Lines 6096 6105 +9
==========================================
- Hits 5464 5442 -22
- Misses 632 663 +31
Continue to review full report at Codecov.
|
milopezc
approved these changes
Jan 20, 2022
AArnott
pushed a commit
that referenced
this pull request
Oct 30, 2024
Bumps [xunit](https://github.com/xunit/xunit) from 2.9.0 to 2.9.1. - [Commits](xunit/xunit@2.9.0...2.9.1) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MEFv2
[OnImportsSatisfied]attribute wasn't handled properly in a few ways. This PR fixes these recently discovered issues.[OnImportsSatisfied]methods in base classes[OnImportsSatisfied]methodsThis includes API breaking changes, but all within the catalog/discovery system, which isn't considered critical since it's essentially for internal use only.
In MEFv2, these would be found.
In VS-MEF they were ignored unless the NonPublic flag was set. VS-MEF is meant to be compatible with V2 without that flag.